Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: sky/sdk/lib/framework/components2/menu_divider.dart

Issue 1163913004: Implement menu_divider (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/examples/stocks2/lib/stock_app.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'dart:sky' as sky;
5 import '../fn2.dart'; 6 import '../fn2.dart';
7 import '../rendering/box.dart';
6 8
7 class MenuDivider extends Component { 9 class MenuDivider extends Component {
8 static final Style _style = new Style(''' 10 static const sky.Color dividerColor = const sky.Color.fromARGB(31, 0, 0, 0);
abarth-chromium 2015/06/04 19:55:42 There's no need to do this if its const anyway.
jackson 2015/06/04 20:10:59 Done.
9 margin: 8px 0;
10 border-bottom: 1px solid rgba(0, 0, 0, 0.12);'''
11 );
12 11
13 MenuDivider({ Object key }) : super(key: key); 12 MenuDivider({ Object key }) : super(key: key);
14 13
15 UINode build() { 14 UINode build() {
16 return new Container( 15 return new Container(
17 style: _style 16 decoration: const BoxDecoration(
abarth-chromium 2015/06/04 19:55:42 The fact that this is const means it will be creat
jackson 2015/06/04 20:10:59 Done.
17 border: const Border(bottom: const BorderSide(color: dividerColor))
18 ),
19 margin: const EdgeDims.symmetric(vertical: 8.0)
18 ); 20 );
19 } 21 }
20 } 22 }
OLDNEW
« no previous file with comments | « sky/examples/stocks2/lib/stock_app.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698