Implement menu_divider

Implement menu_divider

R=abarth@chromium.org, abarth

Committed: https://chromium.googlesource.com/external/mojo/+/8fb6992f089bf6f4ecd78066dee6aa48aaef4aa9

[abarth-chromium, 2015-06-04 19:55:42]

LGTM

https://codereview.chromium.org/1163913004/diff/1/sky/sdk/lib/framework/compo...
File sky/sdk/lib/framework/components2/menu_divider.dart (right):

https://codereview.chromium.org/1163913004/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/menu_divider.dart:10: static const sky.Color
dividerColor = const sky.Color.fromARGB(31, 0, 0, 0);
There's no need to do this if its const anyway.

https://codereview.chromium.org/1163913004/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/menu_divider.dart:16: decoration: const
BoxDecoration(
The fact that this is const means it will be created a compile time and re-used
each runtime.

[jackson, 2015-06-04 20:10:59]

https://codereview.chromium.org/1163913004/diff/1/sky/sdk/lib/framework/compo...
File sky/sdk/lib/framework/components2/menu_divider.dart (right):

https://codereview.chromium.org/1163913004/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/menu_divider.dart:10: static const sky.Color
dividerColor = const sky.Color.fromARGB(31, 0, 0, 0);
On 2015/06/04 19:55:42, abarth wrote:
> There's no need to do this if its const anyway.

Done.

https://codereview.chromium.org/1163913004/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/menu_divider.dart:16: decoration: const
BoxDecoration(
On 2015/06/04 19:55:42, abarth wrote:
> The fact that this is const means it will be created a compile time and
re-used
> each runtime.

Done.

[jackson, 2015-06-04 20:11:45]

Committed patchset #2 (id:20001) manually as
8fb6992f089bf6f4ecd78066dee6aa48aaef4aa9 (presubmit successful).

[Hixie, 2015-06-04 20:36:29]

ianh@google.com changed reviewers:
+ ianh@google.com

[Hixie, 2015-06-04 20:36:29]

lgtm