Source/bindings/scripts/v8_methods.py - Issue 1163893002: binding: Supports static operations/attrs returning non-primitive types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 1163893002: binding: Supports static operations/attrs returning non-primitive types. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Added a comment. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index 870cd4d4c79a51e64810647dadc6d8d0bd864ab8..c19355e08e280e97388cdc7473e1a8cd8ae7871f 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -361,7 +361,7 @@ def v8_set_return_value(interface_name, method, cpp_value, for_main_world=False)

release = idl_type.release

script_wrappable = 'impl' if inherits_interface(interface_name, 'Node') else ''

- return idl_type.v8_set_return_value(cpp_value, extended_attributes, script_wrappable=script_wrappable, release=release, for_main_world=for_main_world)

+ return idl_type.v8_set_return_value(cpp_value, extended_attributes, script_wrappable=script_wrappable, release=release, for_main_world=for_main_world, is_static=method.is_static)

def v8_value_to_local_cpp_variadic_value(method, argument, index, return_promise):

« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »