Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1163863005: Check documentElement conditions in parser* DOM mutation methods (Closed)

Created:
5 years, 6 months ago by esprehn
Modified:
5 years, 6 months ago
Reviewers:
adamk, kouhei (in TOK)
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Check documentElement conditions in parser* DOM mutation methods The parser should never violate the tree constraints by doing something like appending multiple documentElements. The spec says we should just drop these elements on the floor. BUG=492843, 492730 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196371

Patch Set 1 #

Patch Set 2 : Fix pasteboard. #

Patch Set 3 : Add the test again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -18 lines) Patch
M LayoutTests/fast/parser/append-child-followed-by-document-write.html View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
M LayoutTests/fast/parser/append-child-followed-by-document-write-expected.txt View 2 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/dom/ContainerNode.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 4 chunks +19 lines, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 1 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
esprehn
5 years, 6 months ago (2015-06-02 04:25:33 UTC) #2
kouhei (in TOK)
lgtm
5 years, 6 months ago (2015-06-02 04:51:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163863005/1
5 years, 6 months ago (2015-06-02 05:08:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64365)
5 years, 6 months ago (2015-06-02 07:21:12 UTC) #7
esprehn
Okay do you want to look again? I had mess with editing to make this ...
5 years, 6 months ago (2015-06-02 22:09:52 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163863005/40001
5 years, 6 months ago (2015-06-03 02:56:31 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-03 03:55:53 UTC) #13
kouhei (in TOK)
lgtm
5 years, 6 months ago (2015-06-03 05:02:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163863005/40001
5 years, 6 months ago (2015-06-03 05:15:34 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 05:19:21 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196371

Powered by Google App Engine
This is Rietveld 408576698