Issue 1163863002: Fix generated code for callbacks where argument interface doesn't match implementation class name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1163863002: Fix generated code for callbacks where argument interface doesn't match implementation class name (Closed)

Created:
5 years, 6 months ago by jackson

Modified:
5 years, 6 months ago

Reviewers:
mpcomplete, Matt Perry

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix generated code for callbacks where argument interface doesn't match implementation class name R=mpcomplete@chromium.org, mpcomplete Committed: https://chromium.googlesource.com/external/mojo/+/97df8b1ab1fa323772ee5e5d8e8a9f29346f3e40

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	sky/engine/bindings/scripts/dart_types.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

jackson

5 years, 6 months ago (2015-06-01 22:33:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
97df8b1ab1fa323772ee5e5d8e8a9f29346f3e40 (presubmit successful).