Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: sky/engine/bindings/scripts/dart_types.py

Issue 1163863002: Fix generated code for callbacks where argument interface doesn't match implementation class name (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Rebase onto origin/master Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/scripts/dart_types.py
diff --git a/sky/engine/bindings/scripts/dart_types.py b/sky/engine/bindings/scripts/dart_types.py
index 2a063b87a59b9bcdc8a8ba7c7beead79be6f7ca1..7b8ac0f8eaa210ebdf5889441a153baf45858fad 100644
--- a/sky/engine/bindings/scripts/dart_types.py
+++ b/sky/engine/bindings/scripts/dart_types.py
@@ -720,7 +720,7 @@ CPP_VALUE_TO_DART_VALUE = {
'DartValue': 'DartConverter<DartValue*>::ToDart({cpp_value})',
# General
'array': 'VectorToDart({cpp_value})',
- 'DOMWrapper': 'DartConverter<{idl_type}*>::ToDart({cpp_value})',
+ 'DOMWrapper': 'DartConverter<{cpp_type}>::ToDart({cpp_value})',
}
@@ -730,7 +730,7 @@ def cpp_value_to_dart_value(idl_type, cpp_value, creation_context='', extended_a
idl_type, cpp_value = preprocess_idl_type_and_value(idl_type, cpp_value, extended_attributes)
this_dart_conversion_type = idl_type.dart_conversion_type(extended_attributes)
format_string = CPP_VALUE_TO_DART_VALUE[this_dart_conversion_type]
- statement = format_string.format(cpp_value=cpp_value, idl_type=idl_type.base_type)
+ statement = format_string.format(cpp_value=cpp_value, cpp_type=cpp_type(idl_type, raw_type=True))
return statement
IdlTypeBase.cpp_value_to_dart_value = cpp_value_to_dart_value
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698