Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1163843003: don't square error term twice (Closed)

Created:
5 years, 6 months ago by caryclark
Modified:
5 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

don't square error term twice The cubic code erroneously passed the error square term to a function which in turn squares the error term. R=reed@google.com BUG=skia:3877 Committed: https://skia.googlesource.com/skia/+/1bfcaa463650dc4c51cef074dd770a7158b096b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkStroke.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163843003/1
5 years, 6 months ago (2015-06-01 15:31:11 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 6 months ago (2015-06-01 15:31:13 UTC) #3
reed1
lgtm
5 years, 6 months ago (2015-06-01 15:40:28 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 15:40:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1bfcaa463650dc4c51cef074dd770a7158b096b7

Powered by Google App Engine
This is Rietveld 408576698