Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 1163743002: Revert of Include USB printers in printer list as "provisional" devices. (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Include USB printers in printer list as "provisional" devices. (patchset #5 id:80001 of https://codereview.chromium.org/1153173002/) Reason for revert: Looks like this broke at least one test on the official builders (http://crbug.com/493584) Original issue's description: > Include USB printers in printer list as "provisional" devices. > > This patch starts including a list of connected printers supported by > printerProvider apps in the normal list of extension printers returned > to the print preview WebUI. These printers are given "provisional" IDs > because the devices are not yet known to the apps themselves. > > BUG=468955 > > Committed: https://crrev.com/6c3c36136b4567f2225550f15e27d2720e1930d8 > Cr-Commit-Position: refs/heads/master@{#331886} TBR=vitalybuka@chromium.org,tbarzic@chromium.org,rockot@chromium.org,reillyg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=468955 Committed: https://crrev.com/faf208b1a9e95b9f10c74246df9449dcc56fef75 Cr-Commit-Position: refs/heads/master@{#332104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -273 lines) Patch
M chrome/browser/ui/webui/print_preview/extension_printer_handler.h View 4 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/extension_printer_handler.cc View 5 chunks +1 line, -104 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc View 5 chunks +14 lines, -146 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/printer_provider/usb_printer_manifest_data.h View 2 chunks +0 lines, -3 lines 0 comments Download
M extensions/common/api/printer_provider/usb_printer_manifest_data.cc View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Include USB printers in printer list as "provisional" devices.
5 years, 6 months ago (2015-05-30 02:33:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163743002/1
5 years, 6 months ago (2015-05-30 02:33:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-30 02:35:24 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-05-30 02:36:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faf208b1a9e95b9f10c74246df9449dcc56fef75
Cr-Commit-Position: refs/heads/master@{#332104}

Powered by Google App Engine
This is Rietveld 408576698