Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1163693004: [Autofill] Update user-facing strings for server cards (Closed)

Created:
5 years, 6 months ago by Evan Stade
Modified:
5 years, 6 months ago
CC:
chromium-reviews, jam, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Update user-facing strings for server cards BUG=490338 TBR=tedchoc@chromium.org Committed: https://crrev.com/95462a7cdd681b583d32028537973cd63dc3e681 Cr-Commit-Position: refs/heads/master@{#332041}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -94 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 11 chunks +47 lines, -54 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_address.cc View 7 chunks +25 lines, -24 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_items.cc View 4 chunks +10 lines, -10 lines 2 comments Download
M components/autofill_strings.grdp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Evan Stade
https://codereview.chromium.org/1163693004/diff/1/components/autofill/content/browser/wallet/wallet_items.cc File components/autofill/content/browser/wallet/wallet_items.cc (right): https://codereview.chromium.org/1163693004/diff/1/components/autofill/content/browser/wallet/wallet_items.cc#newcode131 components/autofill/content/browser/wallet/wallet_items.cc:131: DLOG(ERROR) << "Response from Google Payments missing card type"; ...
5 years, 6 months ago (2015-05-29 19:34:26 UTC) #2
Evan Stade
+tbr tedchoc for chrome/android/java/strings/android_chrome_strings.grd
5 years, 6 months ago (2015-05-29 19:36:18 UTC) #3
please use gerrit instead
lgtm https://codereview.chromium.org/1163693004/diff/1/components/autofill/content/browser/wallet/wallet_items.cc File components/autofill/content/browser/wallet/wallet_items.cc (right): https://codereview.chromium.org/1163693004/diff/1/components/autofill/content/browser/wallet/wallet_items.cc#newcode131 components/autofill/content/browser/wallet/wallet_items.cc:131: DLOG(ERROR) << "Response from Google Payments missing card ...
5 years, 6 months ago (2015-05-29 19:37:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163693004/1
5 years, 6 months ago (2015-05-29 19:52:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-29 20:49:07 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 20:50:31 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/95462a7cdd681b583d32028537973cd63dc3e681
Cr-Commit-Position: refs/heads/master@{#332041}

Powered by Google App Engine
This is Rietveld 408576698