[Fixit Dec-2012] Refactor first_run, very few things should depend on whether the First Run senti...

chrome/browser/chrome_browser_main.h

Index: chrome/browser/chrome_browser_main.h
diff --git a/chrome/browser/chrome_browser_main.h b/chrome/browser/chrome_browser_main.h
index 5e7cf1eb67e88d0c95d1c04630e7ed7a62aa4f07..90f9190c8d82a4092db924c7408f376aa7def316 100644
--- a/chrome/browser/chrome_browser_main.h
+++ b/chrome/browser/chrome_browser_main.h
@@ -78,8 +78,6 @@ class ChromeBrowserMainParts : public content::BrowserMainParts {
   // in order from PreMainMessageLoopRun(). See implementation for details.
   virtual void PreProfileInit();
   virtual void PostProfileInit();
-  virtual void PreInteractiveFirstRunInit();
-  virtual void PostInteractiveFirstRunInit();
   virtual void PreBrowserStart();
   virtual void PostBrowserStart();
 
@@ -185,8 +183,10 @@ class ChromeBrowserMainParts : public content::BrowserMainParts {
 
   // Members initialized in PreMainMessageLoopRun, needed in
   // PreMainMessageLoopRunThreadsCreated.
-  bool is_first_run_;
-  bool first_run_ui_bypass_;
+  // Whether to do first run tasks. This should be prefered to is_first_run

[cpu_(ooo_6.6-7.5), 2012/12/27 23:53:05]

comment refers to variable or method that does not exist afaik. at least here.

[gab, 2012/12/28 20:17:46]

Ah right, I removed it from the header since it was no longer used in more than
one method; moved the comment to the declaration of is_first_run.

+  // unless the desire is actually to know whether this is really first run
+  // (i.e. even if --no-first-run is passed).
+  bool do_first_run_tasks_;
   PrefService* local_state_;
   FilePath user_data_dir_;