[Fixit Dec-2012] Refactor first_run, very few things should depend on whether the First Run senti...

chrome/browser/chrome_browser_main.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROME_BROWSER_MAIN_H_
 #define CHROME_BROWSER_CHROME_BROWSER_MAIN_H_
 
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 60 matching lines @@
   virtual int PreCreateThreads() OVERRIDE;
   virtual void PreMainMessageLoopRun() OVERRIDE;
   virtual bool MainMessageLoopRun(int* result_code) OVERRIDE;
   virtual void PostMainMessageLoopRun() OVERRIDE;
   virtual void PostDestroyThreads() OVERRIDE;
 
   // Additional stages for ChromeBrowserMainExtraParts. These stages are called
   // in order from PreMainMessageLoopRun(). See implementation for details.
   virtual void PreProfileInit();
   virtual void PostProfileInit();
-  virtual void PreInteractiveFirstRunInit();
-  virtual void PostInteractiveFirstRunInit();
   virtual void PreBrowserStart();
   virtual void PostBrowserStart();
 
 #if !defined(OS_ANDROID)
   // Runs the PageCycler; called if the switch kVisitURLs is present.
   virtual void RunPageCycler();
 #endif
 
   // Override this in subclasses to initialize platform specific field trials.
   virtual void SetupPlatformFieldTrials();
@@ skipping 85 matching lines @@
   TranslateManager* translate_manager_;
   Profile* profile_;
   bool run_message_loop_;
   ProcessSingleton::NotifyResult notify_result_;
 
   // Initialized in SetupMetricsAndFieldTrials.
   scoped_refptr<FieldTrialSynchronizer> field_trial_synchronizer_;
 
   // Members initialized in PreMainMessageLoopRun, needed in
   // PreMainMessageLoopRunThreadsCreated.
-  bool is_first_run_;
-  bool first_run_ui_bypass_;
+  // Whether to do first run tasks. This should be prefered to is_first_run

[cpu_(ooo_6.6-7.5), 2012/12/27 23:53:05]

comment refers to variable or method that does not exist afaik. at least here.

[gab, 2012/12/28 20:17:46]

Ah right, I removed it from the header since it was no longer used in more than
one method; moved the comment to the declaration of is_first_run.

+  // unless the desire is actually to know whether this is really first run
+  // (i.e. even if --no-first-run is passed).
+  bool do_first_run_tasks_;
   PrefService* local_state_;
   FilePath user_data_dir_;
 
   // Members needed across shutdown methods.
   bool restart_last_session_;
 
   // Tests can set this to true to disable restricting cookie access in the
   // network stack, as this can only be done once.
   static bool disable_enforcing_cookie_policies_for_tests_;
 
@@ skipping 18 matching lines @@
 // Records the time from our process' startup to the present time in
 // the Startup.BrowserMessageLoopStartTime UMA histogram.
 void RecordBrowserStartupTime();
 
 // Records a time value to an UMA histogram in the context of the
 // PreReadExperiment field-trial. This also reports to the appropriate
 // sub-histogram (_PreRead(Enabled|Disabled)).
 void RecordPreReadExperimentTime(const char* name, base::TimeDelta time);
 
 #endif  // CHROME_BROWSER_CHROME_BROWSER_MAIN_H_