Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11636006: WIP: The Bookmark Position Megapatch (Closed)

Created:
8 years ago by rlarocque
Modified:
7 years, 8 months ago
Reviewers:
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

WIP: The Bookmark Position Megapatch BUG=

Patch Set 1 #

Patch Set 2 : Various updates, including switch suffix to unique_client_tag style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2195 lines, -1984 lines) Patch
M chrome/browser/sync/glue/bookmark_change_processor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 6 chunks +8 lines, -14 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M sync/engine/apply_control_data_updates_unittest.cc View 2 chunks +14 lines, -17 lines 0 comments Download
M sync/engine/apply_updates_and_resolve_conflicts_command_unittest.cc View 9 chunks +20 lines, -23 lines 0 comments Download
M sync/engine/build_commit_command.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sync/engine/build_commit_command.cc View 5 chunks +8 lines, -80 lines 0 comments Download
D sync/engine/build_commit_command_unittest.cc View 1 chunk +0 lines, -105 lines 0 comments Download
M sync/engine/conflict_resolver.cc View 4 chunks +10 lines, -77 lines 0 comments Download
M sync/engine/get_commit_ids_command.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/engine/process_commit_response_command.cc View 5 chunks +6 lines, -25 lines 0 comments Download
M sync/engine/process_commit_response_command_unittest.cc View 12 chunks +192 lines, -141 lines 0 comments Download
M sync/engine/process_updates_command.cc View 2 chunks +14 lines, -8 lines 0 comments Download
M sync/engine/process_updates_command_unittest.cc View 1 6 chunks +81 lines, -8 lines 0 comments Download
M sync/engine/syncer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/syncer.cc View 3 chunks +3 lines, -20 lines 0 comments Download
M sync/engine/syncer_unittest.cc View 1 65 chunks +168 lines, -325 lines 0 comments Download
M sync/engine/syncer_util.h View 3 chunks +15 lines, -30 lines 0 comments Download
M sync/engine/syncer_util.cc View 1 9 chunks +52 lines, -74 lines 0 comments Download
M sync/internal_api/base_node.cc View 1 5 chunks +9 lines, -37 lines 0 comments Download
M sync/internal_api/change_reorder_buffer.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M sync/internal_api/public/base/unique_position.h View 1 3 chunks +4 lines, -15 lines 0 comments Download
M sync/internal_api/public/base/unique_position.cc View 1 10 chunks +22 lines, -54 lines 0 comments Download
M sync/internal_api/public/base/unique_position_unittest.cc View 1 7 chunks +132 lines, -16 lines 0 comments Download
M sync/internal_api/public/base_node.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M sync/internal_api/public/test/test_entry_factory.h View 1 chunk +34 lines, -13 lines 0 comments Download
M sync/internal_api/public/write_node.h View 2 chunks +4 lines, -10 lines 0 comments Download
M sync/internal_api/read_node.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M sync/internal_api/sync_encryption_handler_impl_unittest.cc View 2 chunks +1 line, -25 lines 0 comments Download
M sync/internal_api/sync_manager_impl.h View 1 chunk +0 lines, -9 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 5 chunks +5 lines, -18 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 39 chunks +96 lines, -88 lines 0 comments Download
M sync/internal_api/test/test_entry_factory.cc View 1 6 chunks +107 lines, -21 lines 0 comments Download
M sync/internal_api/write_node.cc View 1 11 chunks +12 lines, -30 lines 0 comments Download
M sync/protocol/bookmark_specifics.proto View 1 chunk +3 lines, -1 line 0 comments Download
M sync/protocol/sync.proto View 3 chunks +39 lines, -29 lines 0 comments Download
M sync/sync.gyp View 1 2 chunks +5 lines, -1 line 0 comments Download
M sync/syncable/directory.h View 1 9 chunks +32 lines, -70 lines 0 comments Download
M sync/syncable/directory.cc View 1 15 chunks +142 lines, -247 lines 0 comments Download
M sync/syncable/directory_backing_store.h View 1 chunk +1 line, -0 lines 0 comments Download
M sync/syncable/directory_backing_store.cc View 1 10 chunks +133 lines, -24 lines 0 comments Download
M sync/syncable/directory_backing_store_unittest.cc View 6 chunks +131 lines, -12 lines 0 comments Download
M sync/syncable/entry.h View 3 chunks +6 lines, -7 lines 0 comments Download
M sync/syncable/entry.cc View 4 chunks +19 lines, -6 lines 0 comments Download
M sync/syncable/entry_kernel.h View 7 chunks +36 lines, -20 lines 0 comments Download
M sync/syncable/entry_kernel.cc View 3 chunks +29 lines, -5 lines 0 comments Download
M sync/syncable/mutable_entry.h View 1 5 chunks +16 lines, -9 lines 0 comments Download
M sync/syncable/mutable_entry.cc View 1 10 chunks +67 lines, -95 lines 0 comments Download
M sync/syncable/nigori_util.cc View 3 chunks +3 lines, -13 lines 0 comments Download
A sync/syncable/parent_child_index.h View 1 chunk +61 lines, -0 lines 0 comments Download
A sync/syncable/parent_child_index.cc View 1 chunk +109 lines, -0 lines 0 comments Download
A sync/syncable/scoped_parent_child_index_updater.h View 1 chunk +32 lines, -0 lines 0 comments Download
A sync/syncable/scoped_parent_child_index_updater.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M sync/syncable/syncable_columns.h View 2 chunks +6 lines, -4 lines 0 comments Download
M sync/syncable/syncable_enum_conversions.h View 1 chunk +3 lines, -1 line 0 comments Download
M sync/syncable/syncable_enum_conversions.cc View 2 chunks +21 lines, -9 lines 0 comments Download
M sync/syncable/syncable_enum_conversions_unittest.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M sync/syncable/syncable_id.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M sync/syncable/syncable_id.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M sync/syncable/syncable_unittest.cc View 1 46 chunks +98 lines, -86 lines 0 comments Download
M sync/syncable/syncable_util.h View 1 2 chunks +13 lines, -0 lines 0 comments Download
M sync/syncable/syncable_util.cc View 1 3 chunks +28 lines, -18 lines 0 comments Download
M sync/test/engine/mock_connection_manager.h View 4 chunks +20 lines, -0 lines 0 comments Download
M sync/test/engine/mock_connection_manager.cc View 1 6 chunks +56 lines, -3 lines 0 comments Download
M sync/test/engine/test_syncable_utils.cc View 1 chunk +12 lines, -7 lines 0 comments Download
M sync/test/test_directory_backing_store.h View 1 chunk +2 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698