sync/internal_api/public/base_node.h - Issue 11636006: WIP: The Bookmark Position Megapatch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/base_node.h

Issue 11636006: WIP: The Bookmark Position Megapatch (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Various updates, including switch suffix to unique_client_tag style Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/public/base_node.h

diff --git a/sync/internal_api/public/base_node.h b/sync/internal_api/public/base_node.h

index 8afbeaae0bb29dd8b0c8c364828b5c0b89039e2e..b3946fb17c6af85c781bccdf711f41a2fcea73c2 100644

--- a/sync/internal_api/public/base_node.h

+++ b/sync/internal_api/public/base_node.h

@@ -200,11 +200,6 @@ class SYNC_EXPORT BaseNode {

protected:

BaseNode();

virtual ~BaseNode();

- // The server has a size limit on client tags, so we generate a fixed length

- // hash locally. This also ensures that ModelTypes have unique namespaces.

- static std::string GenerateSyncableHash(

- ModelType model_type,

- const std::string& client_tag);

// Determines whether part of the entry is encrypted, and if so attempts to

// decrypt it. Unless decryption is necessary and fails, this will always