Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 11635050: Fix iOS build for XCode 4.6. (Closed)

Created:
8 years ago by Justin Cohen (wrong one)
Modified:
7 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, erikwright+watch_chromium.org, sadrul, sail+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix iOS build for XCode 4.6. The new clang has some bug fixes and is slightly pickier about unused variables. BUG=NONE TBR=mark Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175587

Patch Set 1 #

Total comments: 1

Patch Set 2 : Split new define into multiple lines #

Total comments: 8

Patch Set 3 : nits #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M base/message_pump_mac.mm View 1 2 3 chunks +5 lines, -3 lines 2 comments Download
M chrome/browser/net/connection_tester.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/mac/objc_zombie.mm View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 26 (0 generated)
Justin Cohen (wrong one)
8 years ago (2012-12-20 18:02:15 UTC) #1
stuartmorgan
LGTM with nit. The proxy request ifdefs make me a bit sad, but I don't ...
7 years, 11 months ago (2012-12-31 12:29:27 UTC) #2
Justin Cohen (wrong one)
7 years, 11 months ago (2013-01-02 18:29:15 UTC) #3
Nico
(I ignore emails that cc me on reviews without any comments. If you want me ...
7 years, 11 months ago (2013-01-02 18:33:34 UTC) #4
Justin Cohen (wrong one)
Mark: I need OWNERS approval for message pump mac and objc_zombie. wtc: I need OWNERS ...
7 years, 11 months ago (2013-01-02 18:45:16 UTC) #5
wtc
Patch set 2 LGTM. https://codereview.chromium.org/11635050/diff/5001/base/message_pump_mac.mm File base/message_pump_mac.mm (right): https://codereview.chromium.org/11635050/diff/5001/base/message_pump_mac.mm#newcode30 base/message_pump_mac.mm:30: bool not_using_crapp = false; Nit: ...
7 years, 11 months ago (2013-01-04 00:58:36 UTC) #6
justincohen
https://codereview.chromium.org/11635050/diff/5001/base/message_pump_mac.mm File base/message_pump_mac.mm (right): https://codereview.chromium.org/11635050/diff/5001/base/message_pump_mac.mm#newcode30 base/message_pump_mac.mm:30: bool not_using_crapp = false; On 2013/01/04 00:58:36, wtc wrote: ...
7 years, 11 months ago (2013-01-04 03:54:10 UTC) #7
wtc
Patch set 3 LGTM. Thanks.
7 years, 11 months ago (2013-01-04 14:47:47 UTC) #8
justincohen
rsesek: I need owners approval for chrome/common/mac/objc_zombie.mm Thanks!
7 years, 11 months ago (2013-01-08 18:23:41 UTC) #9
Robert Sesek
chrome/common/mac LGTM https://chromiumcodereview.appspot.com/11635050/diff/12001/base/message_pump_mac.mm File base/message_pump_mac.mm (left): https://chromiumcodereview.appspot.com/11635050/diff/12001/base/message_pump_mac.mm#oldcode29 base/message_pump_mac.mm:29: bool not_using_crapp = false; I think we ...
7 years, 11 months ago (2013-01-08 18:24:55 UTC) #10
justincohen
https://chromiumcodereview.appspot.com/11635050/diff/12001/base/message_pump_mac.mm File base/message_pump_mac.mm (left): https://chromiumcodereview.appspot.com/11635050/diff/12001/base/message_pump_mac.mm#oldcode29 base/message_pump_mac.mm:29: bool not_using_crapp = false; crapp: Heh, I do as ...
7 years, 11 months ago (2013-01-08 18:27:25 UTC) #11
justincohen
Mark, I'm TBRing the change to message_pump_mac so we can get better coverage to look ...
7 years, 11 months ago (2013-01-08 18:30:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/11635050/12001
7 years, 11 months ago (2013-01-08 18:30:24 UTC) #13
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 18:32:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/11635050/12001
7 years, 11 months ago (2013-01-08 18:38:49 UTC) #15
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 18:40:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/11635050/12001
7 years, 11 months ago (2013-01-08 18:51:04 UTC) #17
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 18:53:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/11635050/12001
7 years, 11 months ago (2013-01-08 19:03:20 UTC) #19
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 19:07:05 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/11635050/12001
7 years, 11 months ago (2013-01-08 19:15:35 UTC) #21
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 19:17:45 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/11635050/12001
7 years, 11 months ago (2013-01-08 19:42:39 UTC) #23
commit-bot: I haz the power
Change committed as 175587
7 years, 11 months ago (2013-01-08 21:57:13 UTC) #24
Mark Mentovai
LGTM. It was intentionally crapp.
7 years, 11 months ago (2013-01-14 17:44:34 UTC) #25
wtc
7 years, 11 months ago (2013-01-14 19:44:11 UTC) #26
Message was sent while issue was closed.
On 2013/01/14 17:44:34, Mark Mentovai wrote:
> LGTM. It was intentionally crapp.

This shows my lack of programmer's humor.

Powered by Google App Engine
This is Rietveld 408576698