Fix iOS build for XCode 4.6.

chrome/browser/net/connection_tester.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/connection_tester.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
@@ skipping 32 matching lines @@
 namespace {
 
 // ExperimentURLRequestContext ------------------------------------------------
 
 // An instance of ExperimentURLRequestContext is created for each experiment
 // run by ConnectionTester. The class initializes network dependencies according
 // to the specified "experiment".
 class ExperimentURLRequestContext : public net::URLRequestContext {
  public:
   explicit ExperimentURLRequestContext(
-      net::URLRequestContext* proxy_request_context)
-      : proxy_request_context_(proxy_request_context),
+      net::URLRequestContext* proxy_request_context) :
+#if !defined(OS_IOS)
+        proxy_request_context_(proxy_request_context),

[wtc, 2013/01/04 00:58:36]

Does the compiler warn about an unused class member, but not
an unused constructor argument?

[justincohen, 2013/01/04 03:54:10]

Correct:
chrome/browser/net/connection_tester.cc:289:33: error: private field
'proxy_request_context_' is not used [-Werror,-Wunused-private-field]
  net::URLRequestContext* const proxy_request_context_;


On 2013/01/04 00:58:36, wtc wrote:

+#endif
         ALLOW_THIS_IN_INITIALIZER_LIST(storage_(this)),
         ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {}
 
   virtual ~ExperimentURLRequestContext() {}
 
   // Creates a proxy config service for |experiment|. On success returns net::OK
   // and fills |config_service| with a new pointer. Otherwise returns a network
   // error code.
   int CreateProxyConfigService(
       ConnectionTester::ProxySettingsExperiment experiment,
@@ skipping 214 matching lines @@
         &ExperimentURLRequestContext::FirefoxProxySettingsReply,
         weak_factory_.GetWeakPtr(), config_service,
         base::Owned(ff_settings), callback);
     if (!content::BrowserThread::PostTaskAndReplyWithResult<int>(
             content::BrowserThread::FILE, FROM_HERE, task, reply))
       return net::ERR_FAILED;
     return net::ERR_IO_PENDING;
 #endif
   }
 
+#if !defined(OS_IOS)
   net::URLRequestContext* const proxy_request_context_;
+#endif
   net::URLRequestContextStorage storage_;
   base::WeakPtrFactory<ExperimentURLRequestContext> weak_factory_;
 };
 
 }  // namespace
 
 // ConnectionTester::TestRunner ----------------------------------------------
 
 // TestRunner is a helper class for running an individual experiment. It can
 // be deleted any time after it is started, and this will abort the request.
@@ skipping 234 matching lines @@
 
   // Notify the delegate of completion.
   delegate_->OnCompletedConnectionTestExperiment(current, result);
 
   if (remaining_experiments_.empty()) {
     delegate_->OnCompletedConnectionTestSuite();
   } else {
     StartNextExperiment();
   }
 }