Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: components/password_manager/content/renderer/credential_manager_client.cc

Issue 1163493003: Credential Management: Reorder Web*Credential arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/content/renderer/credential_manager_client.cc
diff --git a/components/password_manager/content/renderer/credential_manager_client.cc b/components/password_manager/content/renderer/credential_manager_client.cc
index 9485ed1f4e7fe711d692a57cfd8a0b840f294d93..b57d3100b2ac1500533dd18f3a64ce9692b33410 100644
--- a/components/password_manager/content/renderer/credential_manager_client.cc
+++ b/components/password_manager/content/renderer/credential_manager_client.cc
@@ -85,11 +85,11 @@ void CredentialManagerClient::OnSendCredential(int request_id,
switch (info.type) {
case CredentialType::CREDENTIAL_TYPE_FEDERATED:
credential.reset(new blink::WebFederatedCredential(
- info.id, info.name, info.avatar, info.federation));
+ info.id, info.federation, info.name, info.avatar));
break;
case CredentialType::CREDENTIAL_TYPE_LOCAL:
credential.reset(new blink::WebLocalCredential(
- info.id, info.name, info.avatar, info.password));
+ info.id, info.password, info.name, info.avatar));
break;
case CredentialType::CREDENTIAL_TYPE_EMPTY:
// Intentionally empty; we'll send nullptr to the onSuccess call below.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698