Source/web/WebLocalFrameImpl.cpp - Issue 1163433003: Remove WebViewImpl helper methods for setting scroll offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 1163433003: Remove WebViewImpl helper methods for setting scroll offset. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index 7f1419d3d9cfcee8c913fc95965de2874d87167a..976f27ca4093ce89693f8d308997eea6b83021f8 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -691,7 +691,7 @@ WebSize WebLocalFrameImpl::maximumScrollOffset() const

void WebLocalFrameImpl::setScrollOffset(const WebSize& offset)

{

if (FrameView* view = frameView())

- view->setScrollOffset(IntPoint(offset.width, offset.height));

+ view->notifyScrollPositionChanged(IntPoint(offset.width, offset.height));

skobes 2015/06/03 16:57:57 One step closer to making FrameView::setScrollOffs

bokan 2015/06/03 17:04:58 I made it private in the mega patch :)

}

WebSize WebLocalFrameImpl::contentsSize() const

« no previous file with comments | « Source/web/FullscreenController.cpp ('k') | Source/web/WebViewImpl.h » ('j') | Source/web/WebViewImpl.cpp » ('J')