Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: Source/web/WebLocalFrameImpl.cpp

Issue 1163433003: Remove WebViewImpl helper methods for setting scroll offset. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 673 matching lines...) Expand 10 before | Expand all | Expand 10 after
684 { 684 {
685 FrameView* view = frameView(); 685 FrameView* view = frameView();
686 if (!view) 686 if (!view)
687 return WebSize(); 687 return WebSize();
688 return toIntSize(view->maximumScrollPosition()); 688 return toIntSize(view->maximumScrollPosition());
689 } 689 }
690 690
691 void WebLocalFrameImpl::setScrollOffset(const WebSize& offset) 691 void WebLocalFrameImpl::setScrollOffset(const WebSize& offset)
692 { 692 {
693 if (FrameView* view = frameView()) 693 if (FrameView* view = frameView())
694 view->setScrollOffset(IntPoint(offset.width, offset.height)); 694 view->notifyScrollPositionChanged(IntPoint(offset.width, offset.height)) ;
skobes 2015/06/03 16:57:57 One step closer to making FrameView::setScrollOffs
bokan 2015/06/03 17:04:58 I made it private in the mega patch :)
695 } 695 }
696 696
697 WebSize WebLocalFrameImpl::contentsSize() const 697 WebSize WebLocalFrameImpl::contentsSize() const
698 { 698 {
699 if (FrameView* view = frameView()) 699 if (FrameView* view = frameView())
700 return view->contentsSize(); 700 return view->contentsSize();
701 return WebSize(); 701 return WebSize();
702 } 702 }
703 703
704 bool WebLocalFrameImpl::hasVisibleContent() const 704 bool WebLocalFrameImpl::hasVisibleContent() const
(...skipping 1403 matching lines...) Expand 10 before | Expand all | Expand 10 after
2108 { 2108 {
2109 m_frameWidget = frameWidget; 2109 m_frameWidget = frameWidget;
2110 } 2110 }
2111 2111
2112 WebFrameWidgetImpl* WebLocalFrameImpl::frameWidget() const 2112 WebFrameWidgetImpl* WebLocalFrameImpl::frameWidget() const
2113 { 2113 {
2114 return m_frameWidget; 2114 return m_frameWidget;
2115 } 2115 }
2116 2116
2117 } // namespace blink 2117 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698