Issue 1163373007: Change the ColorFilter constructor to ColorFilter.Mode, in case we want to add

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1163373007: Change the ColorFilter constructor to ColorFilter.Mode, in case we want to add (Closed)

Created:
5 years, 6 months ago by Matt Perry

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium, eseidel

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Change the ColorFilter constructor to ColorFilter.Mode, in case we want to add more ColorFilter types. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6fe90228b0c995149999aed53446aa21bf2b4dc1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -4 lines)			Patch
M	sky/engine/core/core.gni	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	sky/engine/core/painting/ColorFilter.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	sky/engine/core/painting/ColorFilter.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/examples/game/lib/sprite_node.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/examples/raw/painting.sky	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Matt Perry

5 years, 6 months ago (2015-06-09 18:55:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6fe90228b0c995149999aed53446aa21bf2b4dc1 (presubmit successful).