Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 1163333002: Update roll_angle.py to work on Windows. (Closed)

Created:
5 years, 6 months ago by Geoff Lang
Modified:
5 years, 6 months ago
CC:
chromium-reviews, kjellander_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update roll_angle.py to work on Windows. Also added new features to generate a list of chromium bugs and trigger tryjobs after upload. BUG=489922 Committed: https://crrev.com/44a4fb3ea1b344b993453f9b83f28d32b36b9d20 Cr-Commit-Position: refs/heads/master@{#333579}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -17 lines) Patch
M tools/roll_angle.py View 1 2 7 chunks +50 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Geoff Lang
PTAL
5 years, 6 months ago (2015-06-09 20:22:07 UTC) #2
Ken Russell (switch to Gerrit)
Nice update. LGTM @kjellander: If you like, I'll port the _PosixPath fix back to your ...
5 years, 6 months ago (2015-06-09 20:53:24 UTC) #3
Geoff Lang
On 2015/06/09 20:53:24, Ken Russell wrote: > Nice update. LGTM > > @kjellander: If you ...
5 years, 6 months ago (2015-06-09 20:56:11 UTC) #4
Geoff Lang
Oh, and the change to split the multi-line commit message into separate -m flags is ...
5 years, 6 months ago (2015-06-09 20:57:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163333002/40001
5 years, 6 months ago (2015-06-09 21:08:18 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-09 21:45:44 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/44a4fb3ea1b344b993453f9b83f28d32b36b9d20 Cr-Commit-Position: refs/heads/master@{#333579}
5 years, 6 months ago (2015-06-09 21:46:40 UTC) #10
kjellander (google.com)
On 2015/06/09 20:53:24, Ken Russell wrote: > Nice update. LGTM > > @kjellander: If you ...
5 years, 6 months ago (2015-06-12 12:12:08 UTC) #11
Ken Russell (switch to Gerrit)
On 2015/06/12 12:12:08, kjellander (DO NOT USE THIS) wrote: > On 2015/06/09 20:53:24, Ken Russell ...
5 years, 6 months ago (2015-06-12 21:00:37 UTC) #12
Ken Russell (switch to Gerrit)
5 years, 6 months ago (2015-06-12 21:39:02 UTC) #13
Message was sent while issue was closed.
On 2015/06/12 21:00:37, Ken Russell wrote:
> On 2015/06/12 12:12:08, kjellander (DO NOT USE THIS) wrote:
> > On 2015/06/09 20:53:24, Ken Russell wrote:
> > > Nice update. LGTM
> > > 
> > > @kjellander: If you like, I'll port the _PosixPath fix back to your
> > > roll_webrtc.py script.
> > 
> > If that was all that was needed, please do :)
> 
> @kjellander: per Geoff's comments above, the call to:
>   git config core.autocrlf true
> as well as the splitting of the commit message into multiple lines are both
also
> needed. Are you comfortable making these changes to roll_webrtc.py?

Never mind, not necessary to answer: did the port in
https://codereview.chromium.org/1182263002 .



> 
> > > 
> > > https://codereview.chromium.org/1163333002/diff/20001/tools/roll_angle.py
> > > File tools/roll_angle.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1163333002/diff/20001/tools/roll_angle.py#new...
> > > tools/roll_angle.py:193: # "angleproejct:X" or an ill-formed BUG= message
> > > typo: angleproejct -> angleproject

Powered by Google App Engine
This is Rietveld 408576698