Port Windows changes from roll_angle.py to roll_webrtc.py.

Port Windows changes from roll_angle.py to roll_webrtc.py.

Tested only on Linux, not Windows.

BUG=
TBR=kjellander@chromium.org,tommi@chromium.org

Committed: https://crrev.com/6d4b4b82309d75541a167924d55e82ac4929d710
Cr-Commit-Position: refs/heads/master@{#336274}

[Ken Russell (switch to Gerrit), 2015-06-12 21:38:25]

kbr@chromium.org changed reviewers:
+ kjellander@chromium.org

[Ken Russell (switch to Gerrit), 2015-06-12 21:38:25]

Henrik: please review. Thanks.

Please note I tested this only on Linux with

  tools/roll_webrtc.py --dry-run -v

I verified that it generates correct CL descriptions. (It's a little difficult
to test changes to this script since they have to be committed on the master
branch and they show up in the CL description of the roll.) Sorry, I didn't have
time to test it on Windows.

Geoff: this might inform a bug fix to roll_angle.py. It looks like the
core.autocrlf property should not be set on non-Windows platforms; it messes up
the state of the workspace.

[Ken Russell (switch to Gerrit), 2015-06-24 18:26:59]

kbr@chromium.org changed reviewers:
+ tommi@chromium.org

[Ken Russell (switch to Gerrit), 2015-06-24 18:26:59]

tommi: please review. Thanks.

[Geoff Lang, 2015-06-24 18:34:43]

geofflang@chromium.org changed reviewers:
+ geofflang@chromium.org

[Geoff Lang, 2015-06-24 18:34:44]

Lgtm

https://codereview.chromium.org/1182263002/diff/1/tools/roll_webrtc.py
File tools/roll_webrtc.py (right):

https://codereview.chromium.org/1182263002/diff/1/tools/roll_webrtc.py#newcod...
tools/roll_webrtc.py:179: description.extend(['-m', ''])
You may not need these to generate new lines, each -m is supposed to generate a
new paragraph.

[Ken Russell (switch to Gerrit), 2015-06-25 22:13:56]

kjellander, tommi: I'm going to commit this TBR'd to you both to get it off my
plate.

https://codereview.chromium.org/1182263002/diff/1/tools/roll_webrtc.py
File tools/roll_webrtc.py (right):

https://codereview.chromium.org/1182263002/diff/1/tools/roll_webrtc.py#newcod...
tools/roll_webrtc.py:179: description.extend(['-m', ''])
On 2015/06/24 18:34:44, Geoff Lang wrote:
> You may not need these to generate new lines, each -m is supposed to generate
a
> new paragraph.

Thanks, you're right. Retested locally by forcing the script to produce a no-op
roll.

[Ken Russell (switch to Gerrit), 2015-06-25 22:14:13]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2015-06-25 22:14:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
geofflang@chromium.org
Link to the patchset: https://codereview.chromium.org/1182263002/#ps20001
(title: "Addressed review feedback from geofflang. Removed unnecessary message
lines.")

[commit-bot: I haz the power, 2015-06-25 22:15:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182263002/20001

[commit-bot: I haz the power, 2015-06-25 22:24:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-25 22:25:48]

Patchset 2 (id:??) landed as
https://crrev.com/6d4b4b82309d75541a167924d55e82ac4929d710
Cr-Commit-Position: refs/heads/master@{#336274}