Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3179)

Unified Diff: chrome/browser/ui/webui/options/manage_profile_handler.h

Issue 11633041: Show a delete shortcut checkbox when editing a profile that has a shortcut. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/manage_profile_handler.h
===================================================================
--- chrome/browser/ui/webui/options/manage_profile_handler.h (revision 175855)
+++ chrome/browser/ui/webui/options/manage_profile_handler.h (working copy)
@@ -5,6 +5,9 @@
#ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_MANAGE_PROFILE_HANDLER_H_
#define CHROME_BROWSER_UI_WEBUI_OPTIONS_MANAGE_PROFILE_HANDLER_H_
+#include <string>
+
+#include "base/memory/weak_ptr.h"
#include "chrome/browser/ui/webui/options/options_ui.h"
namespace base {
@@ -44,6 +47,11 @@
// { "name": profileName, "iconURL": iconURL }
void RequestNewProfileDefaults(const base::ListValue* args);
+ // Send all profile icons to the overlay.
+ // |iconGrid| is the string representation of which grid the icons will
James Hawkins 2013/01/09 20:54:58 Phrasing is a little hard to read, consider: ...i
Alexei Svitkine (slow) 2013/01/09 21:54:15 My CL was actually just moving this around to matc
+ // populate (i.e. "create-profile-icon-grid" or "manage-profile-icon-grid").
+ void SendProfileIcons(const base::StringValue& icon_grid);
+
// Sends an object to WebUI of the form:
// profileNames = {
// "Profile Name 1": true,
@@ -70,14 +78,21 @@
// name in the manager profile dialog based on the selected icon.
void ProfileIconSelectionChanged(const base::ListValue* args);
- // Send all profile icons to the overlay.
- // |iconGrid| is the string representation of which grid the icons will
- // populate (i.e. "create-profile-icon-grid" or "manage-profile-icon-grid").
- void SendProfileIcons(const base::StringValue& icon_grid);
+ // Callback for the "requestHasProfileShortcuts" message, which is called
+ // when editing an existing profile. Asks the profile shortcut manager whether
+ // the profile has shortcuts and gets the result in |OnHasProfileShortcuts()|.
+ void RequestHasProfileShortcuts(const base::ListValue* args);
James Hawkins 2013/01/09 20:54:58 Document args.
Alexei Svitkine (slow) 2013/01/09 21:54:15 Done.
+ // Callback invoked from the profile manager indicating whether the profile
+ // being edited has any desktop shortcuts.
+ void OnHasProfileShortcuts(bool has_shortcuts);
+
// URL for the current profile's GAIA picture.
std::string gaia_picture_url_;
+ // For generating weak pointers to itself for callbacks.
+ base::WeakPtrFactory<ManageProfileHandler> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(ManageProfileHandler);
};
« no previous file with comments | « chrome/browser/resources/options/manage_profile_overlay.js ('k') | chrome/browser/ui/webui/options/manage_profile_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698