Show a delete shortcut checkbox when editing a profile that has a shortcut.

chrome/browser/ui/webui/options/manage_profile_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_MANAGE_PROFILE_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_MANAGE_PROFILE_HANDLER_H_
 
+#include <string>
+
+#include "base/memory/weak_ptr.h"
 #include "chrome/browser/ui/webui/options/options_ui.h"
 
 namespace base {
 class StringValue;
 }
 
 namespace options {
 
 // Chrome personal stuff profiles manage overlay UI handler.
 class ManageProfileHandler : public OptionsPageUIHandler {
@@ skipping 19 matching lines @@
   // Callback for the "requestDefaultProfileIcons" message.
   // Sends the array of default profile icon URLs to WebUI.
   // |args| is of the form: [ {string} iconURL ]
   void RequestDefaultProfileIcons(const base::ListValue* args);
 
   // Callback for the "requestNewProfileDefaults" message.
   // Sends an object to WebUI of the form:
   //   { "name": profileName, "iconURL": iconURL }
   void RequestNewProfileDefaults(const base::ListValue* args);
 
+  // Send all profile icons to the overlay.
+  // |iconGrid| is the string representation of which grid the icons will

[James Hawkins, 2013/01/09 20:54:58]

Phrasing is a little hard to read, consider:

...is the string representation of the grid in which the icons will be
populated...

[Alexei Svitkine (slow), 2013/01/09 21:54:15]

My CL was actually just moving this around to match the order in the .cc file.
Though, you're right that the comment was awkward. I've changed it now.

+  // populate (i.e. "create-profile-icon-grid" or "manage-profile-icon-grid").
+  void SendProfileIcons(const base::StringValue& icon_grid);
+
   // Sends an object to WebUI of the form:
   //   profileNames = {
   //     "Profile Name 1": true,
   //     "Profile Name 2": true,
   //     ...
   //   };
   // This is used to detect duplicate profile names.
   void SendProfileNames();
 
   // Callback for the "setProfileNameAndIcon" message. Sets the name and icon
   // of a given profile.
   // |args| is of the form: [
   //   /*string*/ profileFilePath,
   //   /*string*/ newProfileName,
   //   /*string*/ newProfileIconURL
   // ]
   void SetProfileNameAndIcon(const base::ListValue* args);
 
   // Callback for the "deleteProfile" message. Deletes the given profile.
   // |args| is of the form: [ {string} profileFilePath ]
   void DeleteProfile(const base::ListValue* args);
 
   // Callback for the 'profileIconSelectionChanged' message. Used to update the
   // name in the manager profile dialog based on the selected icon.
   void ProfileIconSelectionChanged(const base::ListValue* args);
 
-  // Send all profile icons to the overlay.
-  // |iconGrid| is the string representation of which grid the icons will
-  // populate (i.e. "create-profile-icon-grid" or "manage-profile-icon-grid").
-  void SendProfileIcons(const base::StringValue& icon_grid);
+  // Callback for the "requestHasProfileShortcuts" message, which is called
+  // when editing an existing profile. Asks the profile shortcut manager whether
+  // the profile has shortcuts and gets the result in |OnHasProfileShortcuts()|.
+  void RequestHasProfileShortcuts(const base::ListValue* args);

[James Hawkins, 2013/01/09 20:54:58]

Document args.

[Alexei Svitkine (slow), 2013/01/09 21:54:15]

Done.

+
+  // Callback invoked from the profile manager indicating whether the profile
+  // being edited has any desktop shortcuts.
+  void OnHasProfileShortcuts(bool has_shortcuts);
 
   // URL for the current profile's GAIA picture.
   std::string gaia_picture_url_;
 
+  // For generating weak pointers to itself for callbacks.
+  base::WeakPtrFactory<ManageProfileHandler> weak_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(ManageProfileHandler);
 };
 
 }  // namespace options
 
 #endif  // CHROME_BROWSER_UI_WEBUI_OPTIONS_MANAGE_PROFILE_HANDLER_H_