Show a delete shortcut checkbox when editing a profile that has a shortcut.

Show a delete shortcut checkbox when editing a profile that has a shortcut.

Also makes the presence of the checkboxes in WebUI be based on
ProfileShortcutManager::IsFeatureEnabled().

BUG=162026, 168196
TEST=Edit a profile that has a desktop shortcut. The WebUI should should a delete checkbox that should work as expected. Edit a profile without a shortcut and the checkbox should still be the create one.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175983

[Alexei Svitkine (slow), 2012-12-27 16:56:32]

sail: ProfileShortcutManager stuff
jhawkins: WebUI stuff

[sail, 2012-12-27 23:00:48]

HI Alexei, I'm not convinced that this a good behavior. I'll add my feedback on
the bug. Thanks.

[Alexei Svitkine (slow), 2013-01-04 22:09:22]

From the bug, the new suggested behavior is:

"I propose we have a box, unchecked, that says "Remove desktop shortcut" when a
user has a desktop shortcut."

I'll update the CL next week to implement this, assuming there are further
objections.

[Alexei Svitkine (slow), 2013-01-08 20:47:54]

Show a delete shortcut checkbox when editing a profile that has a shortcut.

[Alexei Svitkine (slow), 2013-01-09 20:32:10]

I've updated the CL to show the "Delete shortcut" checkbox if the profile has
shortcuts already. Please have another look.

sail: profile stuff
jhawkins: webui stuff

Thanks!

[James Hawkins, 2013-01-09 20:54:58]

webui LGTM with nits.

https://codereview.chromium.org/11633041/diff/45009/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/manage_profile_handler.h (right):

https://codereview.chromium.org/11633041/diff/45009/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/manage_profile_handler.h:51: // |iconGrid| is
the string representation of which grid the icons will
Phrasing is a little hard to read, consider:

...is the string representation of the grid in which the icons will be
populated...

https://codereview.chromium.org/11633041/diff/45009/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/manage_profile_handler.h:84: void
RequestHasProfileShortcuts(const base::ListValue* args);
Document args.

[Alexei Svitkine (slow), 2013-01-09 21:54:15]

https://codereview.chromium.org/11633041/diff/45009/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/manage_profile_handler.h (right):

https://codereview.chromium.org/11633041/diff/45009/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/manage_profile_handler.h:51: // |iconGrid| is
the string representation of which grid the icons will
On 2013/01/09 20:54:58, James Hawkins wrote:
> Phrasing is a little hard to read, consider:
> 
> ...is the string representation of the grid in which the icons will be
> populated...

My CL was actually just moving this around to match the order in the .cc file.
Though, you're right that the comment was awkward. I've changed it now.

https://codereview.chromium.org/11633041/diff/45009/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/manage_profile_handler.h:84: void
RequestHasProfileShortcuts(const base::ListValue* args);
On 2013/01/09 20:54:58, James Hawkins wrote:
> Document args.

Done.

[sail, 2013-01-09 21:58:20]

profiles/* LGTM

[commit-bot: I haz the power, 2013-01-09 22:01:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11633041/47005

[commit-bot: I haz the power, 2013-01-10 02:08:41]

Change committed as 175983