Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2020)

Unified Diff: net/quic/quic_client_session.cc

Issue 11633030: Send the ClientHello handshake message. Fix a bug in (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_client_session.cc
===================================================================
--- net/quic/quic_client_session.cc (revision 173961)
+++ net/quic/quic_client_session.cc (working copy)
@@ -53,9 +53,9 @@
};
int QuicClientSession::CryptoConnect(const CompletionCallback& callback) {
- CryptoHandshakeMessage message;
- message.tag = kCHLO;
- crypto_stream_.SendHandshakeMessage(message);
+ if (!crypto_stream_.CryptoConnect()) {
+ return ERR_FAILED; // TODO(wtc): use a better error code.
+ }
wtc 2012/12/20 00:33:08 Do you think |callback| should be passed along to
Ryan Hamilton 2012/12/20 18:51:06 Can we avoid doing so? The internal code does not
if (IsCryptoHandshakeComplete()) {
return OK;

Powered by Google App Engine
This is Rietveld 408576698