Send the ClientHello handshake message. Fix a bug in

net/quic/quic_client_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_client_session.h"
 
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
@@ skipping 35 matching lines @@
 
   ActivateStream(stream);
   return stream;
 }
 
 QuicCryptoClientStream* QuicClientSession::GetCryptoStream() {
   return &crypto_stream_;
 };
 
 int QuicClientSession::CryptoConnect(const CompletionCallback& callback) {
-  CryptoHandshakeMessage message;
-  message.tag = kCHLO;
-  crypto_stream_.SendHandshakeMessage(message);
+  if (!crypto_stream_.CryptoConnect()) {
+    return ERR_FAILED;  // TODO(wtc): use a better error code.
+  }

[wtc, 2012/12/20 00:33:08]

Do you think |callback| should be passed along to crypto_stream_?

[Ryan Hamilton, 2012/12/20 18:51:06]

Can we avoid doing so?  The internal code does not use CompletionCallbacks.

 
   if (IsCryptoHandshakeComplete()) {
     return OK;
   }
 
   callback_ = callback;
   return ERR_IO_PENDING;
 }
 
 ReliableQuicStream* QuicClientSession::CreateIncomingReliableStream(
@@ skipping 61 matching lines @@
     connection()->ProcessUdpPacket(local_address, peer_address, packet);
     if (!connection()->connected()) {
       stream_factory_->OnSessionClose(this);
       return;
     }
     StartReading();
   }
 }
 
 }  // namespace net