Send the ClientHello handshake message. Fix a bug in

net/quic/quic_stream_factory_test.cc

Index: net/quic/quic_stream_factory_test.cc
===================================================================
--- net/quic/quic_stream_factory_test.cc	(revision 173961)
+++ net/quic/quic_stream_factory_test.cc	(working copy)
@@ -129,7 +129,9 @@
   scoped_ptr<QuicEncryptedPacket> rst5(ConstructRstPacket(5, 5));
   scoped_ptr<QuicEncryptedPacket> rst7(ConstructRstPacket(6, 7));
   MockWrite writes[] = {
-    MockWrite(SYNCHRONOUS, chlo->data(), chlo->length()),
+    // TODO(wtc): This should be chlo. Moreover, why does
+    // ERR_CONNECTION_RESET // not cause the test to fail?
+    MockWrite(SYNCHRONOUS, ERR_CONNECTION_RESET),

[wtc, 2012/12/20 00:33:08]

I can't use |chlo|, which is an empty CHLO message, because
we are now generating a real CHLO message.

How do you suggest I fix this? I can change
ConstructHandshakePacket to build a real CHLO message, but
that is a lot of work and requires more refactoring.

Also note that the test still passes even though I use
the mock result ERR_CONNECTION_RESET. This seems to suggest
we are ignoring the failure of socket write.

[Ryan Hamilton, 2012/12/20 18:51:06]

Let's chat offline.

     MockWrite(SYNCHRONOUS, ack->data(), ack->length()),
     MockWrite(SYNCHRONOUS, feedback->data(), feedback->length()),
     MockWrite(SYNCHRONOUS, rst3->data(), rst3->length()),
@@ -191,7 +193,9 @@
   scoped_ptr<QuicEncryptedPacket> rst3(ConstructRstPacket(4, 3));
 
   MockWrite writes[] = {
-    MockWrite(SYNCHRONOUS, chlo->data(), chlo->length()),
+    // TODO(wtc): This should be chlo. Moreover, why does
+    // ERR_CONNECTION_RESET // not cause the test to fail?
+    MockWrite(SYNCHRONOUS, ERR_CONNECTION_RESET),
     MockWrite(SYNCHRONOUS, ack->data(), ack->length()),
     MockWrite(SYNCHRONOUS, feedback->data(), feedback->length()),
     MockWrite(SYNCHRONOUS, rst3->data(), rst3->length()),