Send the ClientHello handshake message. Fix a bug in

net/quic/quic_stream_factory_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_stream_factory.h"
 
 #include "base/rand_util.h"
 #include "base/run_loop.h"
 #include "base/string_util.h"
 #include "net/base/mock_host_resolver.h"
@@ skipping 111 matching lines @@
 }
 
 TEST_F(QuicStreamFactoryTest, Create) {
   scoped_ptr<QuicEncryptedPacket> chlo(ConstructChlo());
   scoped_ptr<QuicEncryptedPacket> ack(ConstructAckPacket(1, 1));
   scoped_ptr<QuicEncryptedPacket> feedback(ConstructFeedbackPacket(3));
   scoped_ptr<QuicEncryptedPacket> rst3(ConstructRstPacket(4, 3));
   scoped_ptr<QuicEncryptedPacket> rst5(ConstructRstPacket(5, 5));
   scoped_ptr<QuicEncryptedPacket> rst7(ConstructRstPacket(6, 7));
   MockWrite writes[] = {
-    MockWrite(SYNCHRONOUS, chlo->data(), chlo->length()),
+    // TODO(wtc): This should be chlo. Moreover, why does
+    // ERR_CONNECTION_RESET // not cause the test to fail?
+    MockWrite(SYNCHRONOUS, ERR_CONNECTION_RESET),

[wtc, 2012/12/20 00:33:08]

I can't use |chlo|, which is an empty CHLO message, because
we are now generating a real CHLO message.

How do you suggest I fix this? I can change
ConstructHandshakePacket to build a real CHLO message, but
that is a lot of work and requires more refactoring.

Also note that the test still passes even though I use
the mock result ERR_CONNECTION_RESET. This seems to suggest
we are ignoring the failure of socket write.

[Ryan Hamilton, 2012/12/20 18:51:06]

Let's chat offline.

     MockWrite(SYNCHRONOUS, ack->data(), ack->length()),
     MockWrite(SYNCHRONOUS, feedback->data(), feedback->length()),
     MockWrite(SYNCHRONOUS, rst3->data(), rst3->length()),
     MockWrite(SYNCHRONOUS, rst5->data(), rst5->length()),
     MockWrite(SYNCHRONOUS, rst7->data(), rst7->length()),
   };
   scoped_ptr<QuicEncryptedPacket> shlo(ConstructShlo());
   scoped_ptr<QuicEncryptedPacket> ack2(ConstructAckPacket(2, 0));
   MockRead reads[] = {
     MockRead(SYNCHRONOUS, shlo->data(), shlo->length()),
@@ skipping 41 matching lines @@
   EXPECT_TRUE(socket_data.at_write_eof());
 }
 
 TEST_F(QuicStreamFactoryTest, CancelCreate) {
   scoped_ptr<QuicEncryptedPacket> chlo(ConstructChlo());
   scoped_ptr<QuicEncryptedPacket> ack(ConstructAckPacket(1, 1));
   scoped_ptr<QuicEncryptedPacket> feedback(ConstructFeedbackPacket(3));
   scoped_ptr<QuicEncryptedPacket> rst3(ConstructRstPacket(4, 3));
 
   MockWrite writes[] = {
-    MockWrite(SYNCHRONOUS, chlo->data(), chlo->length()),
+    // TODO(wtc): This should be chlo. Moreover, why does
+    // ERR_CONNECTION_RESET // not cause the test to fail?
+    MockWrite(SYNCHRONOUS, ERR_CONNECTION_RESET),
     MockWrite(SYNCHRONOUS, ack->data(), ack->length()),
     MockWrite(SYNCHRONOUS, feedback->data(), feedback->length()),
     MockWrite(SYNCHRONOUS, rst3->data(), rst3->length()),
   };
   scoped_ptr<QuicEncryptedPacket> shlo(ConstructShlo());
   scoped_ptr<QuicEncryptedPacket> ack2(ConstructAckPacket(2, 0));
   MockRead reads[] = {
     MockRead(SYNCHRONOUS, shlo->data(), shlo->length()),
     MockRead(SYNCHRONOUS, ack2->data(), ack2->length()),
     MockRead(ASYNC, OK),  // EOF
@@ skipping 14 matching lines @@
       factory_.CreateIfSessionExists(host_port_proxy_pair_, net_log_));
   EXPECT_TRUE(stream.get());
   stream.reset();
 
   EXPECT_TRUE(socket_data.at_read_eof());
   EXPECT_TRUE(socket_data.at_write_eof());
 }
 
 }  // namespace test
 }  // namespace net