Remove ash::window::Show() from BaseLayoutManager::OnWindowActivated

Remove ash::window::Show() from  BaseLayoutManager::OnWindowActivated

This fixes the debug crash here:
DCHECK(!wm::IsWindowMinimized(gained_active))

This is testing kShowStateKey that has not yet been changed to the expected value.

As far as I can tell, when called from OnWindowActivated is already from ash::window::Show
when window.cc calls into the delegate:
   delegate_->OnWindowTargetVisibilityChanged(visible);

Which triggers BrowserView::RestoreFocus which triggers a cascade of focus notifications
ending up in aura::FocusManager::FocusWindow which calls ActivationController::ActivateWindow
which calls BaseLayoutManager::OnWindowActivated

In other word we re-enter and as a side effect the kShowStateKey has not yet been set.

Full stack in the bug.

BUG=166952
TEST=see bug
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175645

[cpu_(ooo_6.6-7.5), 2012-12-19 23:48:32]

I have not tried with the new focus activation manager.

[cpu_(ooo_6.6-7.5), 2013-01-07 22:05:50]

please take a look :)

[Ben Goodger (Google), 2013-01-07 22:10:18]

https://codereview.chromium.org/11633029/diff/1/ash/wm/base_layout_manager.cc
File ash/wm/base_layout_manager.cc (left):

https://codereview.chromium.org/11633029/diff/1/ash/wm/base_layout_manager.cc...
ash/wm/base_layout_manager.cc:157: if (gained_active &&
wm::IsWindowMinimized(gained_active)) {
Can you try running ash_unittests with --use-focus-controller? I bet this breaks
something there.

[Ben Goodger (Google), 2013-01-07 22:11:12]

or rather, can you add to the conditional a check for
views::corewm::UseFocusController() && ..

[cpu_(ooo_6.6-7.5), 2013-01-07 23:58:00]

On 2013/01/07 22:11:12, Ben Goodger (Google) wrote:
> or rather, can you add to the conditional a check for
> views::corewm::UseFocusController() && ..

Tried the ash unit tests with the flag and without and both pass all tests (446
with 29 disabled)

Do you still want me to add the conditional?

[Ben Goodger (Google), 2013-01-08 21:00:15]

Yes I think you broke something else.

[cpu_(ooo_6.6-7.5), 2013-01-08 23:47:53]

code updated please take another look.

[Ben Goodger (Google), 2013-01-08 23:52:32]

thx lgtm