Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: Source/core/loader/EmptyClients.h

Issue 1162953002: Cleanup: Move PopupOpeningObserver ownership from ChromeClient to ChromeClientImpl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/loader/EmptyClients.cpp » ('j') | Source/web/ChromeClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/EmptyClients.h
diff --git a/Source/core/loader/EmptyClients.h b/Source/core/loader/EmptyClients.h
index dbb250f0fdd2532d11e503e52f42b188f2114535..aab8f0e3c55b60ba494c2940623d924053d43d76 100644
--- a/Source/core/loader/EmptyClients.h
+++ b/Source/core/loader/EmptyClients.h
@@ -112,7 +112,7 @@ public:
virtual bool runJavaScriptPromptInternal(LocalFrame*, const String&, const String&, String&) override { return false; }
virtual bool hasOpenedPopup() const override { return false; }
- virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenuInternal(LocalFrame&, PopupMenuClient*) override;
+ virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenu(LocalFrame&, PopupMenuClient*) override;
virtual DOMWindow* pagePopupWindowForTesting() const override { return nullptr; }
virtual void setStatusbarText(const String&) override { }
@@ -136,11 +136,11 @@ public:
virtual void enumerateChosenDirectory(FileChooser*) override { }
- virtual PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooserInternal(LocalFrame*, ColorChooserClient*, const Color&) override;
- virtual PassRefPtr<DateTimeChooser> openDateTimeChooserInternal(DateTimeChooserClient*, const DateTimeChooserParameters&) override;
- virtual void openTextDataListChooserInternal(HTMLInputElement&) override;
+ virtual PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooser(LocalFrame*, ColorChooserClient*, const Color&) override;
+ virtual PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&) override;
+ virtual void openTextDataListChooser(HTMLInputElement&) override;
- virtual void runOpenPanelInternal(LocalFrame*, PassRefPtr<FileChooser>) override;
+ virtual void runOpenPanel(LocalFrame*, PassRefPtr<FileChooser>) override;
virtual void setCursorInternal(const Cursor&) override { }
@@ -153,6 +153,10 @@ public:
virtual void annotatedRegionsChanged() override { }
virtual String acceptLanguages() override;
+
+ virtual void registerPopupOpeningObserver(PopupOpeningObserver*) { };
+ virtual void unregisterPopupOpeningObserver(PopupOpeningObserver*) { };
+ virtual void notifyPopupOpeningObservers() const { };
};
class CORE_EXPORT EmptyFrameLoaderClient : public FrameLoaderClient {
« no previous file with comments | « no previous file | Source/core/loader/EmptyClients.cpp » ('j') | Source/web/ChromeClientImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698