Cleanup: Move PopupOpeningObserver ownership from ChromeClient to ChromeClientImpl.

Source/core/loader/EmptyClients.h

 /*
  * Copyright (C) 2006 Eric Seidel (eric@webkit.org)
  * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
@@ skipping 94 matching lines @@
     virtual bool canRunBeforeUnloadConfirmPanel() override { return false; }
     virtual bool runBeforeUnloadConfirmPanelInternal(LocalFrame*, const String&) override { return true; }
 
     virtual void closeWindowSoon() override { }
 
     virtual void runJavaScriptAlertInternal(LocalFrame*, const String&) override { }
     virtual bool runJavaScriptConfirmInternal(LocalFrame*, const String&) override { return false; }
     virtual bool runJavaScriptPromptInternal(LocalFrame*, const String&, const String&, String&) override { return false; }
 
     virtual bool hasOpenedPopup() const override { return false; }
-    virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenuInternal(LocalFrame&, PopupMenuClient*) override;
+    virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenu(LocalFrame&, PopupMenuClient*) override;
     virtual DOMWindow* pagePopupWindowForTesting() const override { return nullptr; }
 
     virtual void setStatusbarText(const String&) override { }
 
     virtual bool tabsToLinks() override { return false; }
 
     virtual IntRect windowResizerRect() const override { return IntRect(); }
 
     virtual void invalidateRect(const IntRect&) override { }
     virtual void scheduleAnimation() override { }
 
     virtual IntRect viewportToScreen(const IntRect& r) const override { return r; }
     virtual WebScreenInfo screenInfo() const override { return WebScreenInfo(); }
     virtual void contentsSizeChanged(LocalFrame*, const IntSize&) const override { }
 
     virtual void showMouseOverURL(const HitTestResult&) override { }
 
     virtual void setToolTip(const String&, TextDirection) override { }
 
     virtual void printInternal(LocalFrame*) override { }
 
     virtual void enumerateChosenDirectory(FileChooser*) override { }
 
-    virtual PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooserInternal(LocalFrame*, ColorChooserClient*, const Color&) override;
-    virtual PassRefPtr<DateTimeChooser> openDateTimeChooserInternal(DateTimeChooserClient*, const DateTimeChooserParameters&) override;
-    virtual void openTextDataListChooserInternal(HTMLInputElement&) override;
+    virtual PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooser(LocalFrame*, ColorChooserClient*, const Color&) override;
+    virtual PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&) override;
+    virtual void openTextDataListChooser(HTMLInputElement&) override;
 
-    virtual void runOpenPanelInternal(LocalFrame*, PassRefPtr<FileChooser>) override;
+    virtual void runOpenPanel(LocalFrame*, PassRefPtr<FileChooser>) override;
 
     virtual void setCursorInternal(const Cursor&) override { }
 
     virtual void attachRootGraphicsLayer(GraphicsLayer*, LocalFrame* localRoot) override { }
 
     virtual void needTouchEvents(bool) override { }
     virtual void setTouchAction(TouchAction touchAction) override { };
 
     virtual void didAssociateFormControls(const WillBeHeapVector<RefPtrWillBeMember<Element>>&, LocalFrame* frame) override { }
 
     virtual void annotatedRegionsChanged() override { }
     virtual String acceptLanguages() override;
+
+    virtual void registerPopupOpeningObserver(PopupOpeningObserver*) { };
+    virtual void unregisterPopupOpeningObserver(PopupOpeningObserver*) { };
+    virtual void notifyPopupOpeningObservers() const { };
 };
 
 class CORE_EXPORT EmptyFrameLoaderClient : public FrameLoaderClient {
     WTF_MAKE_NONCOPYABLE(EmptyFrameLoaderClient); WTF_MAKE_FAST_ALLOCATED(EmptyFrameLoaderClient);
 public:
     EmptyFrameLoaderClient() { }
     virtual ~EmptyFrameLoaderClient() {  }
 
     virtual bool hasWebView() const override { return true; } // mainly for assertions
 
@@ skipping 143 matching lines @@
     virtual ~EmptyDragClient() {}
     virtual DragDestinationAction actionMaskForDrag(DragData*) override { return DragDestinationActionNone; }
     virtual void startDrag(DragImage*, const IntPoint&, const IntPoint&, DataTransfer*, LocalFrame*, bool) override { }
 };
 
 CORE_EXPORT void fillWithEmptyClients(Page::PageClients&);
 
 } // namespace blink
 
 #endif // EmptyClients_h