Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1162903002: Avoid creating too many handles during array/object literals compilation. (Closed)

Created:
5 years, 6 months ago by Igor Sheludko
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid creating too many handles during array/object literals compilation. BUG=chromium:493289 LOG=N

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/ast.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-493289.js View 1 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Igor Sheludko
PTAL
5 years, 6 months ago (2015-06-01 17:43:07 UTC) #2
Jakob Kummerow
LGTM with a nit. https://codereview.chromium.org/1162903002/diff/1/test/mjsunit/regress/regress-crbug-493289.js File test/mjsunit/regress/regress-crbug-493289.js (right): https://codereview.chromium.org/1162903002/diff/1/test/mjsunit/regress/regress-crbug-493289.js#newcode5 test/mjsunit/regress/regress-crbug-493289.js:5: // Flags: --allow-natives-syntax --harmony-arrays --gc-interval=456 ...
5 years, 6 months ago (2015-06-02 09:46:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162903002/20001
5 years, 6 months ago (2015-06-02 09:52:15 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 10:25:42 UTC) #8 
Try jobs failed on following builders:
  v8_win64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/5267)

Powered by Google App Engine
This is Rietveld 408576698