src/ast.cc - Issue 1162903002: Avoid creating too many handles during array/object literals compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 1162903002: Avoid creating too many handles during array/object literals compilation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index 73cd013a8138f373899e7f324179160e4aa69295..983fcc1d77b7f1343ce0e002c1323fa1e7295d91 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -504,6 +504,7 @@ void ArrayLiteral::BuildConstantElements(Isolate* isolate) {

depth_acc = m_literal->depth() + 1;

}

+ HandleScope loop_scope(isolate);

Handle<Object> boilerplate_value = GetBoilerplateValue(element, isolate);

if (boilerplate_value->IsTheHole()) {

is_holey = true;

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-493289.js » ('j') | no next file with comments »