Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2067)

Unified Diff: Source/modules/credentialmanager/FederatedCredential.h

Issue 1162883002: Credential Manager: Align 'FederatedCredential' with the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Test. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/FederatedCredential.h
diff --git a/Source/modules/credentialmanager/FederatedCredential.h b/Source/modules/credentialmanager/FederatedCredential.h
index 2161ed435ed00bef4893d7616015c8e22d0fa8dc..ad5e44897421e11a2698934685e15ef60bffdb09 100644
--- a/Source/modules/credentialmanager/FederatedCredential.h
+++ b/Source/modules/credentialmanager/FederatedCredential.h
@@ -13,30 +13,24 @@
namespace blink {
+class FederatedCredentialData;
class WebFederatedCredential;
class FederatedCredential final : public Credential {
DEFINE_WRAPPERTYPEINFO();
public:
- static FederatedCredential* create(const String& id, const String& federation, ExceptionState& exceptionState)
- {
- return create(id, federation, String(), String(), exceptionState);
- }
-
- static FederatedCredential* create(const String& id, const String& federation, const String& name, ExceptionState& exceptionState)
- {
- return create(id, federation, name, String(), exceptionState);
- }
-
- static FederatedCredential* create(const String& id, const String& federation, const String& name, const String& avatar, ExceptionState&);
+ static FederatedCredential* create(const FederatedCredentialData&, ExceptionState&);
static FederatedCredential* create(WebFederatedCredential*);
// FederatedCredential.idl
- const KURL& federation() const;
+ const KURL& provider() const;
+
+ // TODO(mkwst): This is a stub, as we don't yet have any support on the Chromium-side.
+ const String protocol() const { return String(); }
private:
FederatedCredential(WebFederatedCredential*);
- FederatedCredential(const String& id, const KURL& federation, const String& name, const KURL& avatar);
+ FederatedCredential(const String& id, const KURL& provider, const String& name, const KURL& avatar);
};
} // namespace blink
« no previous file with comments | « Source/modules/credentialmanager/CredentialData.idl ('k') | Source/modules/credentialmanager/FederatedCredential.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698