chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.js - Issue 1162863002: Material PDF: Fix inconsistent behaviour in page selector, update styling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.js

Issue 1162863002: Material PDF: Fix inconsistent behaviour in page selector, update styling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a test for shouldIgnoreKeyEvents Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js ('K') | « chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.html ('k') | chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.js

diff --git a/chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.js b/chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.js

index c943d28b03c1f131e506d70c2d6896143ab0e2d4..d4058d7c0657b5b8d0083ada1cccd09f892231ce 100644

--- a/chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.js

+++ b/chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.js

@@ -20,9 +20,9 @@

docTitle: String,

/**

- * The current index of the page being viewed (0-based).

+ * The number of the page being viewed (1-based).

- pageIndex: Number,

+ pageNo: Number,

/**

* Whether the document has bookmarks.