Chromium Code Reviews| Index: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js |
| diff --git a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js |
| index fb6ff6cdaa6c09b2e9bea6b2e43c7120f7e0d93e..24e95eb66b79e0c91903cf64032b99de75eef766 100644 |
| --- a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js |
| +++ b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js |
| @@ -9,15 +9,6 @@ Polymer({ |
| properties: { |
| /** |
| - * The index of the current page being viewed (0-based). |
| - */ |
| - index: { |
| - type: Number, |
| - value: 0, |
| - observer: 'indexChanged' |
| - }, |
| - |
| - /** |
| * The number of pages the document contains. |
| */ |
| docLength: { |
| @@ -27,29 +18,21 @@ Polymer({ |
| }, |
| /** |
| - * The current entry in the input field (1-based). |
| + * The current page being viewed (1-based). |
| */ |
| pageNo: { |
| type: String, |
| - value: '1', |
| - observer: 'pageNoChanged' |
| - }, |
| + value: '1' |
| + } |
| }, |
| - pageNoChanged: function() { |
| + pageNoCommitted: function(e) { |
|
raymes
2015/06/02 05:45:56
nit: you can remove e
tsergeant
2015/06/03 06:53:11
Done.
|
| var page = parseInt(this.pageNo); |
| - if (!isNaN(page) && page != this.index + 1) { |
| + if (!isNaN(page)) { |
| this.fire('change-page', {page: page - 1}); |
| - } else { |
| - // Repopulate the input. |
| - this.indexChanged(); |
| } |
| }, |
| - indexChanged: function() { |
| - this.pageNo = String(this.index + 1); |
| - }, |
| - |
| docLengthChanged: function() { |
| var numDigits = this.docLength.toString().length; |
| this.$.pageselector.style.width = (numDigits * DIGIT_LENGTH) + 'em'; |