Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1162783003: Sync the URL interfaces with the spec (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the URL interfaces with the spec https://url.spec.whatwg.org/#api [NoInterfaceObject, Exposed=(Window,Worker)] is not a mistake in the spec: https://www.w3.org/Bugs/Public/show_bug.cgi?id=28538 There are no changes to the generated code. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196217

Patch Set 1 #

Patch Set 2 : partial revert #

Patch Set 3 : missed a TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M Source/core/dom/URL.idl View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M Source/core/dom/URLUtils.idl View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/URLUtilsReadOnly.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
5 years, 6 months ago (2015-05-30 22:30:14 UTC) #2
Jens Widell
LGTM
5 years, 6 months ago (2015-06-01 05:51:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162783003/40001
5 years, 6 months ago (2015-06-01 10:35:41 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 11:40:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196217

Powered by Google App Engine
This is Rietveld 408576698