Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: Source/core/dom/URL.idl

Issue 1162783003: Sync the URL interfaces with the spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: missed a TODO Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/URLUtils.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/URL.idl
diff --git a/Source/core/dom/URL.idl b/Source/core/dom/URL.idl
index a2602659bae380c868bee85deeb009f9299ba715..8bd952734b4b7d3621bb795cb31ec216c898639b 100644
--- a/Source/core/dom/URL.idl
+++ b/Source/core/dom/URL.idl
@@ -24,9 +24,11 @@
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// http://url.spec.whatwg.org/#url
+// https://url.spec.whatwg.org/#url
[
+ // TODO(philipj): There should only be one constructor:
+ // Constructor(USVString url, optional USVString base)
Constructor(USVString url),
Constructor(USVString url, USVString base),
Constructor(USVString url, URL base),
@@ -35,9 +37,15 @@
RaisesException=Constructor,
GarbageCollected,
] interface URL {
- // FIXME: should be in separate URLBlob.idl partial interface definition
- // http://dev.w3.org/2006/webapi/FileAPI/#URL-object
- // FIXME: should not be nullable
+ // TODO(philipj): Implement domainToASCII() and domainToUnicode().
+ // crbug.com/493908
+ // static USVString domainToASCII(USVString domain);
+ // static USVString domainToUnicode(USVString domain);
+
+ // TODO(philipj): This should be in a partial interface definition:
+ // File API
+ // https://w3c.github.io/FileAPI/#creating-revoking
+ // TODO(philipj): Neither the return value nor the argument should be nullable.
[RaisesException, CallWith=ExecutionContext] static DOMString? createObjectURL(Blob? blob);
[CallWith=ExecutionContext] static void revokeObjectURL(DOMString url);
};
« no previous file with comments | « no previous file | Source/core/dom/URLUtils.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698