Issue 1162713003: stop passing |level| to WebGraphicsContext3D

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1162713003: stop passing |level| to WebGraphicsContext3D (Closed)

Created:
5 years, 6 months ago by Ken Russell (switch to Gerrit)

Modified:
5 years, 6 months ago

Reviewers:
qinmin, no sievers

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2357

Target Ref:
refs/pending/branch-heads/2357

Project:
chromium

Visibility:
Public.

More Reviews

Description

stop passing |level| to WebGraphicsContext3D |level| is no longer used as a result of crbug.com/443151. So currently video canvas painting is broken as the call has an empty implementation. BUG=485482 Review URL: https://codereview.chromium.org/1138343004 Cr-Commit-Position: refs/heads/master@{#329533} (cherry picked from commit da4ca3a7643509d64f53529fdb63af6a219aee07) R=sievers@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/83c6571b44023a6aacd18cc35c8731c9fa4aa1f9

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/renderer/media/android/webmediaplayer_android.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ken Russell (switch to Gerrit)

5 years, 6 months ago (2015-06-03 00:03:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
83c6571b44023a6aacd18cc35c8731c9fa4aa1f9 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages