Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1138343004: stop passing |level| to WebGraphicsContext3D (Closed)

Created:
5 years, 7 months ago by qinmin
Modified:
5 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

stop passing |level| to WebGraphicsContext3D |level| is no longer used as a result of crbug.com/443151. So currently video canvas painting is broken as the call has an empty implementation. BUG=485482 Committed: https://crrev.com/da4ca3a7643509d64f53529fdb63af6a219aee07 Cr-Commit-Position: refs/heads/master@{#329533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
qinmin
PTAL
5 years, 7 months ago (2015-05-12 22:35:59 UTC) #2
Ken Russell (switch to Gerrit)
Argh! Thank you for tracking this down. LGTM Will this be covered by any of ...
5 years, 7 months ago (2015-05-12 22:57:59 UTC) #3
qinmin
On 2015/05/12 22:57:59, Ken Russell wrote: > Argh! Thank you for tracking this down. LGTM ...
5 years, 7 months ago (2015-05-12 23:15:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138343004/1
5 years, 7 months ago (2015-05-12 23:16:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 00:05:56 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 00:07:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da4ca3a7643509d64f53529fdb63af6a219aee07
Cr-Commit-Position: refs/heads/master@{#329533}

Powered by Google App Engine
This is Rietveld 408576698