Issue 1162573007: Fix RenderParagraph to respect text color.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1162573007: Fix RenderParagraph to respect text color. (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix RenderParagraph to respect text color. I don't think this is the final API we're going to use. I suspect we'll add a TextStyle struct to hold color and size, etc. which back-ends into CSS like this does today. Currently no one uses this color even though it exists. This is one step towards fixing: https://github.com/domokit/mojo/issues/213 R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/46517ae17e803d96b15edc45ff60d0b89882bcba

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -2 lines)			Patch
M	sky/engine/core/painting/Color.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/paragraph.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
A	sky/tests/framework/color_accessors.dart	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A +	sky/tests/framework/color_accessors-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

eseidel

5 years, 6 months ago (2015-06-08 22:22:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
46517ae17e803d96b15edc45ff60d0b89882bcba (presubmit successful).