Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: sky/sdk/lib/framework/rendering/paragraph.dart

Issue 1162573007: Fix RenderParagraph to respect text color. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Fixed null Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/painting/Color.dart ('k') | sky/tests/framework/color_accessors.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'dart:sky' as sky; 5 import 'dart:sky' as sky;
6 import 'box.dart'; 6 import 'box.dart';
7 import 'object.dart'; 7 import 'object.dart';
8 8
9 class RenderInline extends RenderObject { 9 class RenderInline extends RenderObject {
10 String data; 10 String data;
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 _layoutRoot.minWidth = constraints.minWidth; 51 _layoutRoot.minWidth = constraints.minWidth;
52 _layoutRoot.minHeight = constraints.minHeight; 52 _layoutRoot.minHeight = constraints.minHeight;
53 _layoutRoot.maxHeight = constraints.maxHeight; 53 _layoutRoot.maxHeight = constraints.maxHeight;
54 _layoutRoot.layout(); 54 _layoutRoot.layout();
55 // rootElement.width always expands to fill, use maxContentWidth instead. 55 // rootElement.width always expands to fill, use maxContentWidth instead.
56 sky.Element root = _layoutRoot.rootElement; 56 sky.Element root = _layoutRoot.rootElement;
57 size = constraints.constrain(new Size(root.maxContentWidth, root.height)); 57 size = constraints.constrain(new Size(root.maxContentWidth, root.height));
58 } 58 }
59 59
60 void paint(RenderObjectDisplayList canvas) { 60 void paint(RenderObjectDisplayList canvas) {
61 // _layoutRoot.rootElement.style['color'] = 'rgba(' + ...color... + ')'; 61 if (_color != null)
62 _layoutRoot.rootElement.style['color'] =
63 'rgba(${_color.red}, ${_color.green}, ${_color.blue}, ${_color.alpha / 255.0 })';
62 _layoutRoot.paint(canvas); 64 _layoutRoot.paint(canvas);
63 } 65 }
64 66
65 // we should probably expose a way to do precise (inter-glpyh) hit testing 67 // we should probably expose a way to do precise (inter-glpyh) hit testing
66 68
67 String debugDescribeSettings(String prefix) => '${super.debugDescribeSettings( prefix)}${prefix}color: ${color}\n${prefix}text: ${text}\n'; 69 String debugDescribeSettings(String prefix) => '${super.debugDescribeSettings( prefix)}${prefix}color: ${color}\n${prefix}text: ${text}\n';
68 } 70 }
OLDNEW
« no previous file with comments | « sky/engine/core/painting/Color.dart ('k') | sky/tests/framework/color_accessors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698