chrome/browser/resources/settings/settings_menu/settings_menu.html - Issue 1162563004: Upgrade to 1.0 and switch clients to dom-repeat where needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 1162563004: Upgrade to 1.0 and switch clients to dom-repeat where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a layout import and remove the gzipped webanimation in reproduce.sh Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_page/search_page.html ('k') | chrome/browser/resources/settings/settings_page/settings_page_header.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_menu/settings_menu.html

diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html

index fd502b275b75cc731d8217e9be64e95e2275b865..2974530d35e4182469b34a19fb83832e0120f6a9 100644

--- a/chrome/browser/resources/settings/settings_menu/settings_menu.html

+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html

@@ -8,7 +8,7 @@

<paper-menu selected="{{selectedId}}" attr-for-selected="data-id">

- <template is="x-repeat" items="[[pages]]">

+ <template is="dom-repeat" items="[[pages]]">

<paper-icon-item data-id$="[[item.PAGE_ID]]" icon-width="34px">

<iron-icon icon="[[item.icon]]" item-icon></iron-icon>

<span>[[item.pageTitle]]</span>