chrome/browser/resources/settings/settings_menu/settings_menu.html - Issue 1162563004: Upgrade to 1.0 and switch clients to dom-repeat where needed.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 1162563004: Upgrade to 1.0 and switch clients to dom-repeat where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a layout import and remove the gzipped webanimation in reproduce.sh Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_page/search_page.html ('k') | chrome/browser/resources/settings/settings_page/settings_page_header.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/v0_8/polymer/polymer.html">	1 <link rel="import" href="chrome://resources/polymer/v0_8/polymer/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v0_8/iron-icon/iron-icon.htm l">	2 <link rel="import" href="chrome://resources/polymer/v0_8/iron-icon/iron-icon.htm l">

3 <link rel="import" href="chrome://resources/polymer/v0_8/iron-icons/iron-icons.h tml">	3 <link rel="import" href="chrome://resources/polymer/v0_8/iron-icons/iron-icons.h tml">

4 <link rel="import" href="chrome://resources/polymer/v0_8/paper-menu/paper-menu.h tml">	4 <link rel="import" href="chrome://resources/polymer/v0_8/paper-menu/paper-menu.h tml">

5 <link rel="import" href="chrome://resources/polymer/v0_8/paper-item/paper-icon-i tem.html">	5 <link rel="import" href="chrome://resources/polymer/v0_8/paper-item/paper-icon-i tem.html">

6	6

7 <dom-module id="cr-settings-menu">	7 <dom-module id="cr-settings-menu">

8 <link rel="import" type="css" href="settings_menu.css">	8 <link rel="import" type="css" href="settings_menu.css">

9 <template>	9 <template>

10 <paper-menu selected="{{selectedId}}" attr-for-selected="data-id">	10 <paper-menu selected="{{selectedId}}" attr-for-selected="data-id">

11 <template is="x-repeat" items="[[pages]]">	11 <template is="dom-repeat" items="[[pages]]">

12 <paper-icon-item data-id$="[[item.PAGE_ID]]" icon-width="34px">	12 <paper-icon-item data-id$="[[item.PAGE_ID]]" icon-width="34px">

13 <iron-icon icon="[[item.icon]]" item-icon></iron-icon>	13 <iron-icon icon="[[item.icon]]" item-icon></iron-icon>

14 <span>[[item.pageTitle]]</span>	14 <span>[[item.pageTitle]]</span>

15 </paper-icon-item>	15 </paper-icon-item>

16 </template>	16 </template>

17 </paper-menu>	17 </paper-menu>

18 </template>	18 </template>

19 <script src="settings_menu.js"></script>	19 <script src="settings_menu.js"></script>

20 </dom-module>	20 </dom-module>

OLD	NEW