Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: src/compiler/simplified-operator-reducer.cc

Issue 1162563002: [turbofan] Remove the useless SimplifiedOperatorReducer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/simplified-operator-reducer.cc
diff --git a/src/compiler/simplified-operator-reducer.cc b/src/compiler/simplified-operator-reducer.cc
deleted file mode 100644
index d64a95c62ef31348675497c436d6062420b5a9d7..0000000000000000000000000000000000000000
--- a/src/compiler/simplified-operator-reducer.cc
+++ /dev/null
@@ -1,169 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "src/compiler/simplified-operator-reducer.h"
-
-#include "src/compiler/js-graph.h"
-#include "src/compiler/machine-operator.h"
-#include "src/compiler/node-matchers.h"
-#include "src/compiler/operator-properties.h"
-
-namespace v8 {
-namespace internal {
-namespace compiler {
-
-SimplifiedOperatorReducer::SimplifiedOperatorReducer(JSGraph* jsgraph)
- : jsgraph_(jsgraph), simplified_(jsgraph->zone()) {}
-
-
-SimplifiedOperatorReducer::~SimplifiedOperatorReducer() {}
-
-
-Reduction SimplifiedOperatorReducer::Reduce(Node* node) {
- switch (node->opcode()) {
- case IrOpcode::kBooleanNot: {
- HeapObjectMatcher<HeapObject> m(node->InputAt(0));
- if (m.Is(Unique<HeapObject>::CreateImmovable(factory()->false_value()))) {
- return Replace(jsgraph()->TrueConstant());
- }
- if (m.Is(Unique<HeapObject>::CreateImmovable(factory()->true_value()))) {
- return Replace(jsgraph()->FalseConstant());
- }
- if (m.IsBooleanNot()) return Replace(m.node()->InputAt(0));
- break;
- }
- case IrOpcode::kChangeBitToBool: {
- Int32Matcher m(node->InputAt(0));
- if (m.Is(0)) return Replace(jsgraph()->FalseConstant());
- if (m.Is(1)) return Replace(jsgraph()->TrueConstant());
- if (m.IsChangeBoolToBit()) return Replace(m.node()->InputAt(0));
- break;
- }
- case IrOpcode::kChangeBoolToBit: {
- HeapObjectMatcher<HeapObject> m(node->InputAt(0));
- if (m.Is(Unique<HeapObject>::CreateImmovable(factory()->false_value()))) {
- return ReplaceInt32(0);
- }
- if (m.Is(Unique<HeapObject>::CreateImmovable(factory()->true_value()))) {
- return ReplaceInt32(1);
- }
- if (m.IsChangeBitToBool()) return Replace(m.node()->InputAt(0));
- break;
- }
- case IrOpcode::kChangeFloat64ToTagged: {
- Float64Matcher m(node->InputAt(0));
- if (m.HasValue()) return ReplaceNumber(m.Value());
- break;
- }
- case IrOpcode::kChangeInt32ToTagged: {
- Int32Matcher m(node->InputAt(0));
- if (m.HasValue()) return ReplaceNumber(m.Value());
- break;
- }
- case IrOpcode::kChangeTaggedToFloat64: {
- NumberMatcher m(node->InputAt(0));
- if (m.HasValue()) return ReplaceFloat64(m.Value());
- if (m.IsChangeFloat64ToTagged()) return Replace(m.node()->InputAt(0));
- if (m.IsChangeInt32ToTagged()) {
- return Change(node, machine()->ChangeInt32ToFloat64(),
- m.node()->InputAt(0));
- }
- if (m.IsChangeUint32ToTagged()) {
- return Change(node, machine()->ChangeUint32ToFloat64(),
- m.node()->InputAt(0));
- }
- break;
- }
- case IrOpcode::kChangeTaggedToInt32: {
- NumberMatcher m(node->InputAt(0));
- if (m.HasValue()) return ReplaceInt32(DoubleToInt32(m.Value()));
- if (m.IsChangeFloat64ToTagged()) {
- return Change(node, machine()->ChangeFloat64ToInt32(),
- m.node()->InputAt(0));
- }
- if (m.IsChangeInt32ToTagged()) return Replace(m.node()->InputAt(0));
- break;
- }
- case IrOpcode::kChangeTaggedToUint32: {
- NumberMatcher m(node->InputAt(0));
- if (m.HasValue()) return ReplaceUint32(DoubleToUint32(m.Value()));
- if (m.IsChangeFloat64ToTagged()) {
- return Change(node, machine()->ChangeFloat64ToUint32(),
- m.node()->InputAt(0));
- }
- if (m.IsChangeUint32ToTagged()) return Replace(m.node()->InputAt(0));
- break;
- }
- case IrOpcode::kChangeUint32ToTagged: {
- Uint32Matcher m(node->InputAt(0));
- if (m.HasValue()) return ReplaceNumber(FastUI2D(m.Value()));
- break;
- }
- case IrOpcode::kStoreField: {
- // TODO(turbofan): Poor man's store elimination, remove this once we have
- // a fully featured store elimination in place.
- Node* const effect = node->InputAt(2);
- if (effect->op()->Equals(node->op()) && effect->OwnedBy(node) &&
- effect->InputAt(0) == node->InputAt(0)) {
- // The {effect} is a store to the same field in the same object, and
- // {node} is the only effect observer, so we can kill {effect} and
- // instead make {node} depend on the incoming effect to {effect}.
- node->ReplaceInput(2, effect->InputAt(2));
- effect->Kill();
- return Changed(node);
- }
- break;
- }
- default:
- break;
- }
- return NoChange();
-}
-
-
-Reduction SimplifiedOperatorReducer::Change(Node* node, const Operator* op,
- Node* a) {
- DCHECK_EQ(node->InputCount(), OperatorProperties::GetTotalInputCount(op));
- DCHECK_LE(1, node->InputCount());
- node->set_op(op);
- node->ReplaceInput(0, a);
- return Changed(node);
-}
-
-
-Reduction SimplifiedOperatorReducer::ReplaceFloat64(double value) {
- return Replace(jsgraph()->Float64Constant(value));
-}
-
-
-Reduction SimplifiedOperatorReducer::ReplaceInt32(int32_t value) {
- return Replace(jsgraph()->Int32Constant(value));
-}
-
-
-Reduction SimplifiedOperatorReducer::ReplaceNumber(double value) {
- return Replace(jsgraph()->Constant(value));
-}
-
-
-Reduction SimplifiedOperatorReducer::ReplaceNumber(int32_t value) {
- return Replace(jsgraph()->Constant(value));
-}
-
-
-Graph* SimplifiedOperatorReducer::graph() const { return jsgraph()->graph(); }
-
-
-Factory* SimplifiedOperatorReducer::factory() const {
- return jsgraph()->isolate()->factory();
-}
-
-
-MachineOperatorBuilder* SimplifiedOperatorReducer::machine() const {
- return jsgraph()->machine();
-}
-
-} // namespace compiler
-} // namespace internal
-} // namespace v8
« no previous file with comments | « src/compiler/simplified-operator-reducer.h ('k') | test/unittests/compiler/simplified-operator-reducer-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698