Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1162473006: [chromedriver] Include print preview dialog in window handles. (Closed)

Created:
5 years, 6 months ago by samuong
Modified:
5 years, 6 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Include print preview dialog in window handles. BUG=chromedriver:1087 Committed: https://crrev.com/9dab294d14cd641f8faaa8c30b272b2df421f6ae Cr-Commit-Position: refs/heads/master@{#333301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/test/chromedriver/chrome/chrome_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
samuong
5 years, 6 months ago (2015-06-04 23:47:00 UTC) #2
stgao
lgtm
5 years, 6 months ago (2015-06-05 00:02:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162473006/1
5 years, 6 months ago (2015-06-08 18:24:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-08 18:45:22 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 18:46:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9dab294d14cd641f8faaa8c30b272b2df421f6ae
Cr-Commit-Position: refs/heads/master@{#333301}

Powered by Google App Engine
This is Rietveld 408576698