Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.cc

Issue 1162473006: [chromedriver] Include print preview dialog in window handles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/chromedriver/test/run_py_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/chrome_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_impl.cc b/chrome/test/chromedriver/chrome/chrome_impl.cc
index 97225aa0dffc2b95c6f04f2d235c25a0a5e2b139..aedea8df69617fab05b82a76ab56655601fba19c 100644
--- a/chrome/test/chromedriver/chrome/chrome_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_impl.cc
@@ -55,7 +55,8 @@ Status ChromeImpl::GetWebViewIds(std::list<std::string>* web_view_ids) {
if (view.type == WebViewInfo::kPage ||
view.type == WebViewInfo::kApp ||
(view.type == WebViewInfo::kOther &&
- view.url.find("chrome-extension://") == 0)) {
+ (view.url.find("chrome-extension://") == 0 ||
+ view.url == "chrome://print/"))) {
bool found = false;
for (WebViewList::const_iterator web_view_iter = web_views_.begin();
web_view_iter != web_views_.end(); ++web_view_iter) {
« no previous file with comments | « no previous file | chrome/test/chromedriver/test/run_py_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698