Source/core/svg/SVGAnimatedLength.cpp - Issue 1162453002: [svg2] Make SVGLength wrap a CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAnimatedLength.cpp

Issue 1162453002: [svg2] Make SVGLength wrap a CSSPrimitiveValue (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review fixes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGAnimatedLength.cpp

diff --git a/Source/core/svg/SVGAnimatedLength.cpp b/Source/core/svg/SVGAnimatedLength.cpp

index ade7ec10472d24a5d78f0329af3ab220f9deaf7b..de2ff387eedd1f7a195942e5c4e8d69e9f8f1f2e 100644

--- a/Source/core/svg/SVGAnimatedLength.cpp

+++ b/Source/core/svg/SVGAnimatedLength.cpp

@@ -49,7 +49,7 @@ void SVGAnimatedLength::setBaseValueAsString(const String& value, SVGParsingErro

if (es.hadException()) {

parseError = ParsingAttributeFailedError;

- baseValue()->newValueSpecifiedUnits(LengthTypeNumber, 0);

+ baseValue()->newValueSpecifiedUnits(CSSPrimitiveValue::CSS_NUMBER, 0);

} else if (m_negativeValuesMode == ForbidNegativeLengths && baseValue()->valueInSpecifiedUnits() < 0) {

parseError = NegativeValueForbiddenError;

}