Source/core/css/resolver/StyleBuilderConverter.cpp - Issue 1162453002: [svg2] Make SVGLength wrap a CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 1162453002: [svg2] Make SVGLength wrap a CSSPrimitiveValue (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review fixes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/StyleBuilderConverter.cpp

diff --git a/Source/core/css/resolver/StyleBuilderConverter.cpp b/Source/core/css/resolver/StyleBuilderConverter.cpp

index 75b3a6c10977c0ee2f40c4b100cec5a181b02f35..5f6784ada6ffdfd403b6c0733f552172f229248d 100644

--- a/Source/core/css/resolver/StyleBuilderConverter.cpp

+++ b/Source/core/css/resolver/StyleBuilderConverter.cpp

@@ -199,6 +199,8 @@ static float computeFontSize(StyleResolverState& state, CSSPrimitiveValue* primi

return primitiveValue->computeLength<float>(conversionData);

if (primitiveValue->isCalculatedPercentageWithLength())

return primitiveValue->cssCalcValue()->toCalcValue(conversionData)->evaluate(parentSize.value);

+ if (primitiveValue->isNumber())

+ return primitiveValue->getFloatValue();

ASSERT_NOT_REACHED();

return 0;