Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1162383003: C++11: Replace 0 with nullptr where applicable in layout code. (Closed)

Created:
5 years, 6 months ago by wkorman
Modified:
5 years, 6 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-rendering, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, jfernandez, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, Manuel Rego, rwlbuis, Stephen Chennney, svillar, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

C++11: Replace 0 with nullptr where applicable in layout code. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196639

Patch Set 1 #

Patch Set 2 : Add one more file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+592 lines, -606 lines) Patch
M Source/core/layout/BidiRun.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/BidiRunForLine.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/BidiRunForLine.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/ClipRectsCache.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/CounterNode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/CounterNode.cpp View 8 chunks +23 lines, -23 lines 0 comments Download
M Source/core/layout/FloatingObjects.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/HitTestResult.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/ImageQualityController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutBR.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutBlock.h View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 15 chunks +22 lines, -22 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 16 chunks +19 lines, -19 lines 0 comments Download
M Source/core/layout/LayoutBox.h View 10 chunks +19 lines, -19 lines 0 comments Download
M Source/core/layout/LayoutBox.cpp View 9 chunks +12 lines, -12 lines 0 comments Download
M Source/core/layout/LayoutBoxModelObject.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/LayoutBoxModelObject.cpp View 5 chunks +7 lines, -9 lines 0 comments Download
M Source/core/layout/LayoutButton.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutButton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutCounter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutCounter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutEmbeddedObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutFieldset.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutFlexibleBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutFlowThread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutFullScreen.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutGeometryMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutGrid.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutImage.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutImageResource.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutInline.h View 5 chunks +12 lines, -12 lines 0 comments Download
M Source/core/layout/LayoutInline.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M Source/core/layout/LayoutListItem.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/layout/LayoutListMarker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutListMarker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutMenuList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutMultiColumnFlowThread.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 11 chunks +14 lines, -14 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnFlowThreadTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnSet.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutObject.h View 15 chunks +31 lines, -31 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 27 chunks +31 lines, -31 lines 0 comments Download
M Source/core/layout/LayoutObjectChildList.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutPart.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutProgress.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutQuote.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutReplaced.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutReplica.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutRuby.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutRubyBase.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutRubyBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutRubyRun.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutRubyRun.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutScrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutScrollbarPart.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutScrollbarPart.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutState.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutTable.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutTable.cpp View 12 chunks +18 lines, -18 lines 0 comments Download
M Source/core/layout/LayoutTableCell.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTableCell.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTableCol.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutTableCol.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTableRow.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTableRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTableSection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTableSection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutText.h View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/layout/LayoutText.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M Source/core/layout/LayoutTextCombine.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTextControl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTextControl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutTextControlMultiLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutThemeFontProviderWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutVideo.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutView.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/MultiColumnFragmentainerGroupTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/OrderIterator.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/TableLayoutAlgorithmAuto.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/TextAutosizer.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/TextAutosizer.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M Source/core/layout/TextRunConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp View 6 chunks +7 lines, -10 lines 0 comments Download
M Source/core/layout/compositing/CompositingInputsUpdater.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/layout/compositing/CompositingInputsUpdater.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/compositing/CompositingLayerAssigner.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/compositing/CompositingLayerAssigner.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp View 6 chunks +11 lines, -11 lines 0 comments Download
M Source/core/layout/compositing/GraphicsLayerTreeBuilder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/compositing/GraphicsLayerUpdater.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/AbstractInlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/BreakingContextInlineHeaders.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/line/InlineBox.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/line/InlineBox.cpp View 5 chunks +6 lines, -10 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M Source/core/layout/line/InlineIterator.h View 5 chunks +11 lines, -11 lines 0 comments Download
M Source/core/layout/line/InlineTextBox.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/line/LayoutTextInfo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/LineBoxList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/LineBoxList.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/layout/line/LineInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/LineLayoutState.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/RootInlineBox.cpp View 9 chunks +13 lines, -13 lines 0 comments Download
M Source/core/layout/line/TrailingObjects.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/WordMeasurement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGBlock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGGradientStop.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGHiddenContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGInline.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGInlineText.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGInlineText.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGModelObject.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceContainer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGRoot.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGShape.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGText.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGText.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGTransformableContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/ReferenceFilterBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/SVGLayoutSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGMarkerData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGResources.h View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/SVGTextMetrics.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextMetricsBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextQuery.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/line/SVGRootInlineBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/line/SVGRootInlineBox.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
wkorman
Prior discussion that reads as supportive, but open to thoughts as always: https://groups.google.com/a/chromium.org/d/msg/blink-dev/8tpekpcg7Tw/BePB-aGGOG8J https://groups.google.com/a/chromium.org/d/msg/blink-dev/g5xOmbclJVM/NT0E4iVHWCoJ Update ...
5 years, 6 months ago (2015-06-07 23:11:06 UTC) #2
eae
LGTM
5 years, 6 months ago (2015-06-07 23:16:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162383003/20001
5 years, 6 months ago (2015-06-07 23:17:10 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 00:20:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196639

Powered by Google App Engine
This is Rietveld 408576698